Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Jan Beulich
On 25.06.2024 12:43, Andrew Cooper wrote: > On 25/06/2024 8:30 am, Jan Beulich wrote: >> The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other similar >> constructs, should have caught my attention. Turns out it was needed for >> the build to succeed merely because the corresponding #ifnde

Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Andrew Cooper
On 25/06/2024 8:30 am, Jan Beulich wrote: > The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other similar > constructs, should have caught my attention. Turns out it was needed for > the build to succeed merely because the corresponding #ifndef had a > typo. That typo in turn broke compat

Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Jan Beulich
On 25.06.2024 11:24, Roger Pau Monné wrote: > On Tue, Jun 25, 2024 at 09:30:07AM +0200, Jan Beulich wrote: >> The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other similar >> constructs, should have caught my attention. Turns out it was needed for >> the build to succeed merely because the

Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Roger Pau Monné
On Tue, Jun 25, 2024 at 09:30:07AM +0200, Jan Beulich wrote: > The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other similar > constructs, should have caught my attention. Turns out it was needed for > the build to succeed merely because the corresponding #ifndef had a > typo. That typo in

Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Oleksii
On Tue, 2024-06-25 at 09:30 +0200, Jan Beulich wrote: > The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other > similar > constructs, should have caught my attention. Turns out it was needed > for > the build to succeed merely because the corresponding #ifndef had a > typo. That typo in tu

Re: [PATCH for-4.19] gnttab: fix compat query-size handling

2024-06-25 Thread Jan Beulich
On 25.06.2024 09:30, Jan Beulich wrote: > The odd DEFINE_XEN_GUEST_HANDLE(), inconsistent with all other similar > constructs, should have caught my attention. Turns out it was needed for > the build to succeed merely because the corresponding #ifndef had a > typo. That typo in turn broke compat mo