Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-11-11 Thread Oleksandr
On 11.11.20 21:27, Julien Grall wrote: Hi Oleksandr, Hi Julien. On 11/11/2020 00:03, Oleksandr wrote: On 16.10.20 11:41, Julien Grall wrote: On 16/10/2020 07:29, Jan Beulich wrote: On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: @@ -1067,7 +1068,14 @@ static int __p2m_set_entry(struc

Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-11-11 Thread Julien Grall
Hi Oleksandr, On 11/11/2020 00:03, Oleksandr wrote: On 16.10.20 11:41, Julien Grall wrote: On 16/10/2020 07:29, Jan Beulich wrote: On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: @@ -1067,7 +1068,14 @@ static int __p2m_set_entry(struct p2m_domain *p2m,    */   if ( p2m_is_valid(ori

Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-11-10 Thread Oleksandr
On 16.10.20 11:41, Julien Grall wrote: Hi Jan, Julien Sorry for the late response. Hi Jan, On 16/10/2020 07:29, Jan Beulich wrote: On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: @@ -1067,7 +1068,14 @@ static int __p2m_set_entry(struct p2m_domain *p2m,    */   if ( p2m_is_valid(

Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-10-16 Thread Jan Beulich
On 16.10.2020 10:41, Julien Grall wrote: > On 16/10/2020 07:29, Jan Beulich wrote: >> Given how p2m_free_entry() works (or is supposed to work in the >> long run), is the new code you add guaranteed to only alter leaf >> entries? > > This path may also be called with tables. I think we want to mov

Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-10-16 Thread Julien Grall
Hi Jan, On 16/10/2020 07:29, Jan Beulich wrote: On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: @@ -1067,7 +1068,14 @@ static int __p2m_set_entry(struct p2m_domain *p2m, */ if ( p2m_is_valid(orig_pte) && !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) +{ +#i

Re: [PATCH V2 21/23] xen/arm: Add mapcache invalidation handling

2020-10-15 Thread Jan Beulich
On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: > @@ -1067,7 +1068,14 @@ static int __p2m_set_entry(struct p2m_domain *p2m, > */ > if ( p2m_is_valid(orig_pte) && > !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) > +{ > +#ifdef CONFIG_IOREQ_SERVER > +if ( do