Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 12:00, Andrew Cooper wrote: > On 20/03/2025 10:18 am, Jan Beulich wrote: >> On 20.03.2025 10:53, Jan Beulich wrote: >>> On 20.03.2025 09:34, Jan Beulich wrote: On 20.03.2025 09:14, Roger Pau Monné wrote: > I wonder how this worked then, as I've tested with the xen.efi smoke >

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Andrew Cooper
On 20/03/2025 10:18 am, Jan Beulich wrote: > On 20.03.2025 10:53, Jan Beulich wrote: >> On 20.03.2025 09:34, Jan Beulich wrote: >>> On 20.03.2025 09:14, Roger Pau Monné wrote: I wonder how this worked then, as I've tested with the xen.efi smoke test in gitlab CI. Maybe ovmf doesn't ackno

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 09:34, Jan Beulich wrote: > On 20.03.2025 09:14, Roger Pau Monné wrote: >> I wonder how this worked then, as I've tested with the xen.efi smoke >> test in gitlab CI. Maybe ovmf doesn't acknowledge the RX sections and >> unconditionally sets all mappings as writable? > > Possible. An

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 10:53, Jan Beulich wrote: > On 20.03.2025 09:34, Jan Beulich wrote: >> On 20.03.2025 09:14, Roger Pau Monné wrote: >>> I wonder how this worked then, as I've tested with the xen.efi smoke >>> test in gitlab CI. Maybe ovmf doesn't acknowledge the RX sections and >>> unconditionally se

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Jan Beulich
On 20.03.2025 09:14, Roger Pau Monné wrote: > On Wed, Mar 19, 2025 at 11:46:22AM +0100, Jan Beulich wrote: >> On 19.03.2025 11:32, Jan Beulich wrote: >>> On 18.03.2025 18:35, Roger Pau Monne wrote: Relocations are now applied after having moved the trampoline, >>> >>> That's two entirely diffe

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-20 Thread Roger Pau Monné
On Wed, Mar 19, 2025 at 11:46:22AM +0100, Jan Beulich wrote: > On 19.03.2025 11:32, Jan Beulich wrote: > > On 18.03.2025 18:35, Roger Pau Monne wrote: > >> Relocations are now applied after having moved the trampoline, > > > > That's two entirely different sets of relocations, isn't it? Right, t

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 19.03.2025 11:46, Jan Beulich wrote: > On 19.03.2025 11:32, Jan Beulich wrote: >> On 18.03.2025 18:35, Roger Pau Monne wrote: >>> Relocations are now applied after having moved the trampoline, >> >> That's two entirely different sets of relocations, isn't it? What we generate >> here is what is

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 19.03.2025 11:32, Jan Beulich wrote: > On 18.03.2025 18:35, Roger Pau Monne wrote: >> Relocations are now applied after having moved the trampoline, > > That's two entirely different sets of relocations, isn't it? What we generate > here is what is to be encoded in the PE binary's .reloc sectio

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-19 Thread Jan Beulich
On 18.03.2025 18:35, Roger Pau Monne wrote: > Relocations are now applied after having moved the trampoline, That's two entirely different sets of relocations, isn't it? What we generate here is what is to be encoded in the PE binary's .reloc section, for the PE loader to process. And for us to th

Re: [PATCH 5/7] x86/mkreloc: remove warning about relocations to RO section

2025-03-18 Thread Andrew Cooper
On 18/03/2025 5:35 pm, Roger Pau Monne wrote: > Relocations are now applied after having moved the trampoline, so there's no > reason to warn about relocations to read-only sections. The logic that > apply the relocations would make sure they are applied against writable > mappings. > > Signed-off