Re: [PATCH 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-03-14 Thread Jan Beulich
On 14.03.2022 16:32, Roger Pau Monné wrote: > On Mon, Feb 14, 2022 at 05:44:01PM +0100, Jan Beulich wrote: >> On 01.02.2022 17:46, Roger Pau Monne wrote: >>> + ASSERT(core->count <= c->x86_num_siblings); >>> + if ((enable && core->count == 1) || >>> + (!enable && core->count == 0)) >> >>

Re: [PATCH 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-03-14 Thread Roger Pau Monné
On Mon, Feb 14, 2022 at 05:44:01PM +0100, Jan Beulich wrote: > On 01.02.2022 17:46, Roger Pau Monne wrote: > > + ASSERT(core->count <= c->x86_num_siblings); > > + if ((enable && core->count == 1) || > > + (!enable && core->count == 0)) > > Maybe simply "if ( core->count == enable )"? Or

Re: [PATCH 3/3] amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD

2022-02-14 Thread Jan Beulich
On 01.02.2022 17:46, Roger Pau Monne wrote: > @@ -716,26 +702,117 @@ void amd_init_ssbd(const struct cpuinfo_x86 *c) > if (rdmsr_safe(MSR_AMD64_LS_CFG, val) || > ({ > val &= ~mask; > - if (opt_ssbd) > +