Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
> The whole point of running ‘go build’ is to make sure that *the code we just > copied* — the code right now in our own local tree, perhaps which was just > generated — actually compiles. I understand that, and in my tests that's the outcome. > It looks like when we add the `go.mod` further up

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 6:30 PM, George Dunlap wrote: > >> >> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: >> >> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments >> unless you have verified the sender and know the content is safe. >> >> On Tue, May 12, 2020 at 1

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 10:36 AM George Dunlap > wrote: >> >> >> >>> On Apr 30, 2020, a

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
> For trademark reasons, when we joined the Linux Foundation, we did a big > rebranding from “Xen” to “XenProject”. (See [1] for more details.) The > xen.org domains are just for backwards compatibility. :-) Ah, thanks! I'll fix that. -NR

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On May 12, 2020, at 4:06 PM, Nick Rosbrook wrote: > > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On Tue, May 12, 2020 at 10:36 AM George Dunlap > wrote: >> >> >> >>> On Apr 30, 2020,

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread Nick Rosbrook
On Tue, May 12, 2020 at 10:36 AM George Dunlap wrote: > > > > > On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > > > Initialize the xenlight Go module using the xenbits git-http URL, > > xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the > > XEN_GOCODE_URL variable in to

Re: [PATCH 2/3] golang/xenlight: init xenlight go module

2020-05-12 Thread George Dunlap
> On Apr 30, 2020, at 10:39 PM, Nick Rosbrook wrote: > > Initialize the xenlight Go module using the xenbits git-http URL, > xenbits.xen.org/git-http/xen.git/tools/golang/xenlight, and update the > XEN_GOCODE_URL variable in tools/Rules.mk accordingly. > > Signed-off-by: Nick Rosbrook > --- >