Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-14 Thread Stefano Stabellini
Hi Jan, I apologize for the confusion. I initially believed this patch would reduce the outstanding violations to zero on x86, but in reality, there are still 1,415 remaining. https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/10660702979 Given this, I believe we should consider global

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-10 Thread Jan Beulich
On 10.07.2025 02:35, Stefano Stabellini wrote: > On Wed, 9 Jul 2025, Jan Beulich wrote: >>> What fine grained deviation do you have in mind? >> >> Ones for almost(?) everything that is having actual code changes right now >> in this series. > > We could easily deviate alternative.c based on the fi

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-09 Thread Stefano Stabellini
On Wed, 9 Jul 2025, Jan Beulich wrote: > > What fine grained deviation do you have in mind? > > Ones for almost(?) everything that is having actual code changes right now > in this series. We could easily deviate alternative.c based on the file name alone. But for the rest: emulate.c: casts from

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-08 Thread Jan Beulich
On 08.07.2025 19:32, Stefano Stabellini wrote: > On Tue, 8 Jul 2025, Jan Beulich wrote: >> On 08.07.2025 00:00, Stefano Stabellini wrote: >>> On Tue, 24 Jun 2025, Jan Beulich wrote: On 24.06.2025 02:20, victorm.l...@amd.com wrote: > From: Nicola Vetrini > > Use {get,put}_unaligned

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-08 Thread Stefano Stabellini
On Tue, 8 Jul 2025, Jan Beulich wrote: > On 08.07.2025 00:00, Stefano Stabellini wrote: > > On Tue, 24 Jun 2025, Jan Beulich wrote: > >> On 24.06.2025 02:20, victorm.l...@amd.com wrote: > >>> From: Nicola Vetrini > >>> > >>> Use {get,put}_unaligned_t to ensure that reads and writes are > >>> safe

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-08 Thread Jan Beulich
On 08.07.2025 00:00, Stefano Stabellini wrote: > On Tue, 24 Jun 2025, Jan Beulich wrote: >> On 24.06.2025 02:20, victorm.l...@amd.com wrote: >>> From: Nicola Vetrini >>> >>> Use {get,put}_unaligned_t to ensure that reads and writes are >>> safe to perform even on potentially misaligned pointers. >

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-07-07 Thread Stefano Stabellini
On Tue, 24 Jun 2025, Jan Beulich wrote: > On 24.06.2025 02:20, victorm.l...@amd.com wrote: > > From: Nicola Vetrini > > > > Use {get,put}_unaligned_t to ensure that reads and writes are > > safe to perform even on potentially misaligned pointers. > > Also applicable to the Arm patch: Please can

Re: [PATCH 2/2] xen/x86: address violations of Rule 11.3

2025-06-24 Thread Jan Beulich
On 24.06.2025 02:20, victorm.l...@amd.com wrote: > From: Nicola Vetrini > > Use {get,put}_unaligned_t to ensure that reads and writes are > safe to perform even on potentially misaligned pointers. Also applicable to the Arm patch: Please can such patches mention the main subject of the rule, not