On 07.12.2021 13:00, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a
> switch statement"):
>> I'm unwilling only as long as I don't understand the need for them. As
>> indicated, while I appreciate your "ma
Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch
statement"):
> I'm unwilling only as long as I don't understand the need for them. As
> indicated, while I appreciate your "make verification easier for
> reviewers", I assign t
On 07.12.2021 10:59, Julien Grall wrote:
> On 07/12/2021 09:11, Jan Beulich wrote:
>> On 06.12.2021 17:21, Julien Grall wrote:
>>> I still have have no way to verify
>>> what you did is correct.
>>>
>>> For instance, the tags in patch #2 are:
>>>
>>> Link: http://lkml.kernel.org/r/20191104185107.3b
Hi,
On 07/12/2021 09:11, Jan Beulich wrote:
On 06.12.2021 17:21, Julien Grall wrote:
Hi Jan,
On 06/12/2021 16:12, Jan Beulich wrote:
On 06.12.2021 17:06, Julien Grall wrote:
On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
I am not going to ack it but I am a
On 06.12.2021 17:21, Julien Grall wrote:
> Hi Jan,
>
> On 06/12/2021 16:12, Jan Beulich wrote:
>> On 06.12.2021 17:06, Julien Grall wrote:
>>> On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
> I am not going to ack it but I am also not going to Nack it if
On 06.12.2021 17:45, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH 1/7] xz: add fall-through comments to a
> switch statement"):
>> On 06/12/2021 16:12, Jan Beulich wrote:
>>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>
Julien Grall writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch
statement"):
> On 06/12/2021 16:12, Jan Beulich wrote:
> > Hmm, I did address both your and Ian's concerns in v2, admittedly by only
> > going as far as minimally necessary. I therefore w
On 06/12/2021 16:24, Jan Beulich wrote:
On 06.12.2021 17:21, Julien Grall wrote:
On 06/12/2021 16:12, Jan Beulich wrote:
On 06.12.2021 17:06, Julien Grall wrote:
On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
I am not going to ack it but I am also not goi
On 06.12.2021 17:21, Julien Grall wrote:
> On 06/12/2021 16:12, Jan Beulich wrote:
>> On 06.12.2021 17:06, Julien Grall wrote:
>>> On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
> I am not going to ack it but I am also not going to Nack it if another
>
Hi Jan,
On 06/12/2021 16:12, Jan Beulich wrote:
On 06.12.2021 17:06, Julien Grall wrote:
On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
I am not going to ack it but I am also not going to Nack it if another
maintainer agrees with your approach.
FTAOD I'll b
On 06.12.2021 17:06, Julien Grall wrote:
> On 06/12/2021 15:06, Jan Beulich wrote:
>> On 06.12.2021 15:28, Julien Grall wrote:
>>> I am not going to ack it but I am also not going to Nack it if another
>>> maintainer agrees with your approach.
>>
>> FTAOD I'll be giving it a week or so, but unless
Hi,
On 06/12/2021 15:06, Jan Beulich wrote:
On 06.12.2021 15:28, Julien Grall wrote:
On 06/12/2021 13:44, Jan Beulich wrote:
On 26.11.2021 13:52, Ian Jackson wrote:
Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch
statement"):
On 26.11.2021 11:04, Ju
On 06.12.2021 15:28, Julien Grall wrote:
> On 06/12/2021 13:44, Jan Beulich wrote:
>> On 26.11.2021 13:52, Ian Jackson wrote:
>>> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a
>>> switch statement"):
>>>> On 26.11.2021 11
Hi Jan,
On 06/12/2021 13:44, Jan Beulich wrote:
On 26.11.2021 13:52, Ian Jackson wrote:
Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch
statement"):
On 26.11.2021 11:04, Julien Grall wrote:
For this case, you provided some sort of an explanation but
On 26.11.2021 13:52, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a
> switch statement"):
>> On 26.11.2021 11:04, Julien Grall wrote:
>>> For this case, you provided some sort of an explanation but so far, I am
>>
Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch
statement"):
> On 26.11.2021 11:04, Julien Grall wrote:
> > For this case, you provided some sort of an explanation but so far, I am
> > still waiting for a link to confirm that the signed-off
On 26.11.2021 11:04, Julien Grall wrote:
> Hi Jan,
>
> On 26/11/2021 09:12, Jan Beulich wrote:
>>> Anyway, I think it would save time for everyone (you had to manually
>>> delete signed-off-by after all) if you just copy the commit (including
>>> all the signed-off-by) message as-is.
>>
>> I don't
Hi Jan,
On 26/11/2021 09:12, Jan Beulich wrote:
Anyway, I think it would save time for everyone (you had to manually
delete signed-off-by after all) if you just copy the commit (including
all the signed-off-by) message as-is.
I don't think I see why you found it necessary to verify the S-o-b s
On 26.11.2021 10:03, Julien Grall wrote:
> On 26/11/2021 07:37, Jan Beulich wrote:
>> On 25.11.2021 18:13, Julien Grall wrote:
>>> On 25/11/2021 17:03, Jan Beulich wrote:
On 25.11.2021 17:54, Julien Grall wrote:
> On 25/11/2021 16:49, Julien Grall wrote:
>> On 19/11/2021 10:21, Jan Beu
Hi Jan,
On 26/11/2021 07:37, Jan Beulich wrote:
On 25.11.2021 18:13, Julien Grall wrote:
Hi,
On 25/11/2021 17:03, Jan Beulich wrote:
On 25.11.2021 17:54, Julien Grall wrote:
On 25/11/2021 16:49, Julien Grall wrote:
On 19/11/2021 10:21, Jan Beulich wrote:
From: Lasse Collin
It's good styl
On 25.11.2021 18:13, Julien Grall wrote:
> Hi,
>
> On 25/11/2021 17:03, Jan Beulich wrote:
>> On 25.11.2021 17:54, Julien Grall wrote:
>>> On 25/11/2021 16:49, Julien Grall wrote:
On 19/11/2021 10:21, Jan Beulich wrote:
> From: Lasse Collin
>
> It's good style. I was also told th
Hi,
On 25/11/2021 17:03, Jan Beulich wrote:
On 25.11.2021 17:54, Julien Grall wrote:
On 25/11/2021 16:49, Julien Grall wrote:
On 19/11/2021 10:21, Jan Beulich wrote:
From: Lasse Collin
It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are
On 25.11.2021 17:54, Julien Grall wrote:
> On 25/11/2021 16:49, Julien Grall wrote:
>> On 19/11/2021 10:21, Jan Beulich wrote:
>>> From: Lasse Collin
>>>
>>> It's good style. I was also told that GCC 7 is more strict and might
>>> give a warning when such comments are missing.
>>>
>>> Suggested-by
On 25/11/2021 16:49, Julien Grall wrote:
On 19/11/2021 10:21, Jan Beulich wrote:
From: Lasse Collin
It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are missing.
Suggested-by: Andrei Borzenkov
Signed-off-by: Lasse Collin
Actually, a
Hi Jan,
On 19/11/2021 10:21, Jan Beulich wrote:
From: Lasse Collin
It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are missing.
Suggested-by: Andrei Borzenkov
Signed-off-by: Lasse Collin
[Linux commit: 5a244f48ecbbd03a11eb84819c5c599db8
25 matches
Mail list logo
