Re: [PATCH 1/7] xen/bitops: Cleanup ahead of rearrangements

2024-03-14 Thread Jan Beulich
On 13.03.2024 18:27, Andrew Cooper wrote: > * Rename __attribute_pure__ to just __pure before it gains users. > * Identify the areas of xen/bitops.h which are a mess. > * Create common/bitops.c for compile and runtime testing. This provides a >statement of the ABI, and a confirmation that a

Re: [PATCH 1/7] xen/bitops: Cleanup ahead of rearrangements

2024-03-13 Thread Andrew Cooper
On 13/03/2024 5:27 pm, Andrew Cooper wrote: > diff --git a/xen/common/bitops.c b/xen/common/bitops.c > new file mode 100644 > index ..4c07191b4030 > --- /dev/null > +++ b/xen/common/bitops.c > @@ -0,0 +1,41 @@ > +#include > +#include > +#include > + > +/* Hide a value from the optimi

Re: [PATCH 1/7] xen/bitops: Cleanup ahead of rearrangements

2024-03-13 Thread Shawn Anastasio
Hi Andrew, On 3/13/24 12:27 PM, Andrew Cooper wrote: > diff --git a/xen/common/bitops.c b/xen/common/bitops.c > new file mode 100644 > index ..4c07191b4030 > --- /dev/null > +++ b/xen/common/bitops.c > @@ -0,0 +1,41 @@ > +#include > +#include > +#include > + > +/* Hide a value from