Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-07-29 Thread Marek Marczykowski-Górecki
On Fri, Jun 27, 2025 at 02:08:00PM +0100, Frediano Ziglio wrote: > On Thu, Jun 5, 2025 at 12:17 PM Andrew Cooper > wrote: > > > > The format of the buildid is a property of the binary, not a property of how > > it was loaded. This fixes buildid recognition when starting xen.efi from > > it's >

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-07-29 Thread Daniel Smith
On Thu, 05 Jun 2025 07:16:36 -0400 Andrew Cooper wrote --- > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from > it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Si

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-30 Thread Roger Pau Monné
On Thu, Jun 05, 2025 at 12:16:36PM +0100, Andrew Cooper wrote: > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Signed-off-by: Andrew

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-27 Thread Frediano Ziglio
On Thu, Jun 5, 2025 at 12:17 PM Andrew Cooper wrote: > > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Signed-off-by: Andrew Cooper

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-24 Thread Jan Beulich
On 23.06.2025 22:18, Andrew Cooper wrote: > On 16/06/2025 7:27 am, Jan Beulich wrote: >> To expand on my earlier suggestion (ab)using the "efi" global: With >> the linker script having this >> >> #ifdef EFI >> .reloc ALIGN(4) : { >> __base_relocs_start = .; >> *(.reloc) >> __base_relo

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-23 Thread Andrew Cooper
On 16/06/2025 7:27 am, Jan Beulich wrote: > To expand on my earlier suggestion (ab)using the "efi" global: With > the linker script having this > > #ifdef EFI > .reloc ALIGN(4) : { > __base_relocs_start = .; > *(.reloc) > __base_relocs_end = .; > } > #elif defined(XEN_BUILD_EFI) >

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-15 Thread Jan Beulich
On 13.06.2025 23:28, Andrew Cooper wrote: > On 10/06/2025 9:01 am, Jan Beulich wrote: >> On 06.06.2025 17:01, Andrew Cooper wrote: >>> On 06/06/2025 8:22 am, Jan Beulich wrote: And then, based on your reasoning above, why don't you also drop the #ifdef CONFIG_X86? >>> Because that's the o

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-13 Thread Stefano Stabellini
On Fri, 6 Jun 2025, Jan Beulich wrote: > > But the argument I'm going to make this this:  Why do you want a check, > > even if you can find a correct one (and as said before, I cannot)? > > > > This function is run exactly once.  We've excluded "nothing given by the > > toolchain", and excluded "w

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-13 Thread Andrew Cooper
On 10/06/2025 9:01 am, Jan Beulich wrote: > On 06.06.2025 17:01, Andrew Cooper wrote: >> On 06/06/2025 8:22 am, Jan Beulich wrote: >>> On 05.06.2025 19:01, Andrew Cooper wrote: On 05/06/2025 2:24 pm, Jan Beulich wrote: > On 05.06.2025 14:14, Andrew Cooper wrote: >> On 05/06/2025 1:02 p

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-10 Thread Jan Beulich
On 06.06.2025 17:01, Andrew Cooper wrote: > On 06/06/2025 8:22 am, Jan Beulich wrote: >> On 05.06.2025 19:01, Andrew Cooper wrote: >>> On 05/06/2025 2:24 pm, Jan Beulich wrote: On 05.06.2025 14:14, Andrew Cooper wrote: > On 05/06/2025 1:02 pm, Jan Beulich wrote: >> On 05.06.2025 13:16,

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-06 Thread Andrew Cooper
On 06/06/2025 8:22 am, Jan Beulich wrote: > On 05.06.2025 19:01, Andrew Cooper wrote: >> On 05/06/2025 2:24 pm, Jan Beulich wrote: >>> On 05.06.2025 14:14, Andrew Cooper wrote: On 05/06/2025 1:02 pm, Jan Beulich wrote: > On 05.06.2025 13:16, Andrew Cooper wrote: This really is a prope

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-06 Thread Jan Beulich
On 06.06.2025 09:22, Jan Beulich wrote: > On 05.06.2025 19:01, Andrew Cooper wrote: >> On 05/06/2025 2:24 pm, Jan Beulich wrote: >>> On 05.06.2025 14:14, Andrew Cooper wrote: On 05/06/2025 1:02 pm, Jan Beulich wrote: > On 05.06.2025 13:16, Andrew Cooper wrote: This really is a propert

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-06 Thread Jan Beulich
On 05.06.2025 19:01, Andrew Cooper wrote: > On 05/06/2025 2:24 pm, Jan Beulich wrote: >> On 05.06.2025 14:14, Andrew Cooper wrote: >>> On 05/06/2025 1:02 pm, Jan Beulich wrote: On 05.06.2025 13:16, Andrew Cooper wrote: >>> This really is a property of being a PE32+ binary, and nothing to do >>

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Andrew Cooper
On 05/06/2025 2:24 pm, Jan Beulich wrote: > On 05.06.2025 14:14, Andrew Cooper wrote: >> On 05/06/2025 1:02 pm, Jan Beulich wrote: >>> On 05.06.2025 13:16, Andrew Cooper wrote: The format of the buildid is a property of the binary, not a property of how it was loaded. This fixes bu

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Marek Marczykowski-Górecki
On Thu, Jun 05, 2025 at 03:08:07PM +0200, Jan Beulich wrote: > On 05.06.2025 14:20, Marek Marczykowski-Górecki wrote: > > On Thu, Jun 05, 2025 at 02:02:21PM +0200, Jan Beulich wrote: > >> On 05.06.2025 13:16, Andrew Cooper wrote: > >>> The format of the buildid is a property of the binary, not a pr

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Jan Beulich
On 05.06.2025 14:14, Andrew Cooper wrote: > On 05/06/2025 1:02 pm, Jan Beulich wrote: >> On 05.06.2025 13:16, Andrew Cooper wrote: >>> The format of the buildid is a property of the binary, not a property of how >>> it was loaded. This fixes buildid recognition when starting xen.efi from >>> it's

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Jan Beulich
On 05.06.2025 14:20, Marek Marczykowski-Górecki wrote: > On Thu, Jun 05, 2025 at 02:02:21PM +0200, Jan Beulich wrote: >> On 05.06.2025 13:16, Andrew Cooper wrote: >>> The format of the buildid is a property of the binary, not a property of how >>> it was loaded. This fixes buildid recognition when

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Marek Marczykowski-Górecki
On Thu, Jun 05, 2025 at 02:02:21PM +0200, Jan Beulich wrote: > On 05.06.2025 13:16, Andrew Cooper wrote: > > The format of the buildid is a property of the binary, not a property of how > > it was loaded. This fixes buildid recognition when starting xen.efi from > > it's > > MB2 entrypoint. > >

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Andrew Cooper
On 05/06/2025 1:02 pm, Jan Beulich wrote: > On 05.06.2025 13:16, Andrew Cooper wrote: >> The format of the buildid is a property of the binary, not a property of how >> it was loaded. This fixes buildid recognition when starting xen.efi from >> it's >> MB2 entrypoint. >> >> Suggested-by: Ross Lag

Re: [PATCH 1/3] x86/EFI: Fix detection of buildid

2025-06-05 Thread Jan Beulich
On 05.06.2025 13:16, Andrew Cooper wrote: > The format of the buildid is a property of the binary, not a property of how > it was loaded. This fixes buildid recognition when starting xen.efi from it's > MB2 entrypoint. > > Suggested-by: Ross Lagerwall > Signed-off-by: Andrew Cooper I'll pick t