Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-17 Thread Jan Beulich
On 17.07.2020 11:22, Julien Grall wrote: > > > On 17/07/2020 09:16, Jan Beulich wrote: >> On 16.07.2020 18:17, Julien Grall wrote: >>> On Thu, 16 Jul 2020, 17:01 Jan Beulich, wrote: >>> On 16.07.2020 16:42, Roger Pau Monné wrote: > On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich w

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-17 Thread Julien Grall
On 17/07/2020 09:16, Jan Beulich wrote: On 16.07.2020 18:17, Julien Grall wrote: On Thu, 16 Jul 2020, 17:01 Jan Beulich, wrote: On 16.07.2020 16:42, Roger Pau Monné wrote: On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote: On 16.07.2020 13:41, Roger Pau Monné wrote: On Wed, Ju

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-17 Thread Jan Beulich
On 16.07.2020 18:17, Julien Grall wrote: > On Thu, 16 Jul 2020, 17:01 Jan Beulich, wrote: > >> On 16.07.2020 16:42, Roger Pau Monné wrote: >>> On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote: On 16.07.2020 13:41, Roger Pau Monné wrote: > On Wed, Jul 15, 2020 at 12:15:10PM +02

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-16 Thread Julien Grall
On Thu, 16 Jul 2020, 17:01 Jan Beulich, wrote: > On 16.07.2020 16:42, Roger Pau Monné wrote: > > On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote: > >> On 16.07.2020 13:41, Roger Pau Monné wrote: > >>> On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: > Use ENXIO instea

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-16 Thread Jan Beulich
On 16.07.2020 16:42, Roger Pau Monné wrote: > On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote: >> On 16.07.2020 13:41, Roger Pau Monné wrote: >>> On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: Use ENXIO instead of EINVAL to cover the two cases of the address not

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-16 Thread Roger Pau Monné
On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote: > On 16.07.2020 13:41, Roger Pau Monné wrote: > > On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: > >> Use ENXIO instead of EINVAL to cover the two cases of the address not > >> satisfying the requirements. This will make an

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-16 Thread Jan Beulich
On 16.07.2020 13:41, Roger Pau Monné wrote: > On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: >> Use ENXIO instead of EINVAL to cover the two cases of the address not >> satisfying the requirements. This will make an issue here better stand >> out at the call site. > > Not sure whethe

Re: [PATCH 1/2] common: map_vcpu_info() cosmetics

2020-07-16 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: > Use ENXIO instead of EINVAL to cover the two cases of the address not > satisfying the requirements. This will make an issue here better stand > out at the call site. Not sure whether I would use EFAULT instead of ENXIO, as the descrip