Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-07 Thread Julien Grall
On 07/04/2021 09:33, Jan Beulich wrote: On 06.04.2021 21:34, Julien Grall wrote: Hi Jan, On 01/04/2021 16:23, Jan Beulich wrote: On 01.04.2021 16:56, Julien Grall wrote: On 01/04/2021 11:19, Jan Beulich wrote: --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF T

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-07 Thread Jan Beulich
On 06.04.2021 21:34, Julien Grall wrote: > Hi Jan, > > On 01/04/2021 16:23, Jan Beulich wrote: >> On 01.04.2021 16:56, Julien Grall wrote: >>> On 01/04/2021 11:19, Jan Beulich wrote: --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF THE USE OF THIS SO

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-06 Thread Julien Grall
Hi Jan, On 01/04/2021 16:23, Jan Beulich wrote: On 01.04.2021 16:56, Julien Grall wrote: On 01/04/2021 11:19, Jan Beulich wrote: --- a/xen/common/lib.c +++ b/xen/lib/divmod.c @@ -40,7 +40,6 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. *

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-01 Thread Jan Beulich
On 01.04.2021 16:56, Julien Grall wrote: > On 01/04/2021 11:19, Jan Beulich wrote: >> --- a/xen/common/lib.c >> +++ b/xen/lib/divmod.c >> @@ -40,7 +40,6 @@ >>* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF >>* SUCH DAMAGE. >>*/ >> -#if BITS_PER_LONG == 32 > > I

Re: [PATCH 02/23] lib: move 64-bit div/mod compiler helpers

2021-04-01 Thread Julien Grall
Hi Jan, On 01/04/2021 11:19, Jan Beulich wrote: These were built for 32-bit architectures only (the same code could, with some tweaking, sensibly be used to provide TI-mode helpers on 64-bit arch-es) - retain this property, while still avoiding to have a CU without any contents at all. For this,