Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-25 Thread Oleksandr Andrushchenko
Hello, Jan! On 24.02.25 12:55, Jan Beulich wrote: On 23.02.2025 08:42, Oleksandr Andrushchenko wrote: On 20.02.25 03:34, Stefano Stabellini wrote: On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: Yes, I do agree. But only if we talk about having an automated code style check now (which is

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-24 Thread Jan Beulich
On 23.02.2025 08:42, Oleksandr Andrushchenko wrote: > On 20.02.25 03:34, Stefano Stabellini wrote: >> On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: >>> Yes, I do agree. But only if we talk about having an automated >>> code style check now (which is definitely the goal at some time). >>> Befo

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-22 Thread Oleksandr Andrushchenko
Hello, Stefano! On 20.02.25 03:34, Stefano Stabellini wrote: On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: Yes, I do agree. But only if we talk about having an automated code style check now (which is definitely the goal at some time). Before that we could still use the tool to take all t

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Stefano Stabellini
On Wed, 19 Feb 2025, Oleksandr Andrushchenko wrote: > Yes, I do agree. But only if we talk about having an automated > code style check now (which is definitely the goal at some time). > Before that we could still use the tool to take all that good that > it does and manually prepare a set of patch

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Andrew Cooper
On 19/02/2025 1:19 pm, Oleksandr Andrushchenko wrote: > > > On 19.02.25 14:51, Oleksandr Andrushchenko wrote: >> Hello, Andrew! >> >> On 19.02.25 14:49, Andrew Cooper wrote: >>> On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: Hello, Roger! Please find the branch with all the co

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
On 19.02.25 14:51, Oleksandr Andrushchenko wrote: Hello, Andrew! On 19.02.25 14:49, Andrew Cooper wrote: On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff --igno

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan! On 19.02.25 14:49, Jan Beulich wrote: On 19.02.2025 13:43, Oleksandr Andrushchenko wrote: Hello, Jan, Stefano! On 18.02.25 13:34, Jan Beulich wrote: On 18.02.2025 03:36, Stefano Stabellini wrote: On Mon, 17 Feb 2025, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenk

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Andrew! On 19.02.25 14:49, Andrew Cooper wrote: On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff --ignore-all-space as such a patch will not simply apply. S

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Grygorii! On 18.02.25 11:56, Grygorii Strashko wrote: On 16.02.25 12:21, Oleksandr Andrushchenko wrote: Hello, everybody! As agreed before [1] I am sending a series to show two samples of the formatting done with clang-format. The clang-format configuration can be found at [2]. It alr

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Jan Beulich
On 19.02.2025 13:43, Oleksandr Andrushchenko wrote: > Hello, Jan, Stefano! > > On 18.02.25 13:34, Jan Beulich wrote: >> On 18.02.2025 03:36, Stefano Stabellini wrote: >>> On Mon, 17 Feb 2025, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: > 1. Const string arrays r

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Andrew Cooper
On 16/02/2025 5:11 pm, Oleksandr Andrushchenko wrote: > Hello, Roger! > > Please find the branch with all the conversions [1]. > Unfortunately I cannot provide a branch as seen with > diff --ignore-all-space as such a patch will not simply apply. > > Stay safe, > Oleksandr Andrushchenko > > On 16.0

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-19 Thread Oleksandr Andrushchenko
Hello, Jan, Stefano! On 18.02.25 13:34, Jan Beulich wrote: On 18.02.2025 03:36, Stefano Stabellini wrote: On Mon, 17 Feb 2025, Jan Beulich wrote: On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: 1. Const string arrays reformatting In case the length of items change we might need to introdu

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-18 Thread Roger Pau Monné
On Tue, Feb 18, 2025 at 11:56:48AM +0200, Grygorii Strashko wrote: > Honestly, It looks a bit strange that Xen community is considering batch > automated code formatting, > For example Linux kernel cleanly rejected such approach. > Linux kernel docs "4.1.1. Coding style" section [1]. > > Another

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-18 Thread Jan Beulich
On 18.02.2025 03:36, Stefano Stabellini wrote: > On Mon, 17 Feb 2025, Jan Beulich wrote: >> On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: >>> 1. Const string arrays reformatting >>> In case the length of items change we might need to introduce a bigger >>> change wrt new formatting of unaffec

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-18 Thread Luca Fancellu
Hi Oleksandr, > > 2. Long strings in ptintk violations > I filed an issue on printk format strings [5] > == > @@ -225,9 +231,9 @@ void __init acpi_table_print_madt_entry(struct > acpi_subtable_header *header) > p

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-18 Thread Grygorii Strashko
On 16.02.25 12:21, Oleksandr Andrushchenko wrote: Hello, everybody! As agreed before [1] I am sending a series to show two samples of the formatting done with clang-format. The clang-format configuration can be found at [2]. It already has some notes on previous discussions when Luca presente

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-17 Thread Stefano Stabellini
On Mon, 17 Feb 2025, Jan Beulich wrote: > On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: > > 1. Const string arrays reformatting > > In case the length of items change we might need to introduce a bigger > > change wrt new formatting of unaffected lines > >

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-17 Thread Jan Beulich
On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: > 1. Const string arrays reformatting > In case the length of items change we might need to introduce a bigger > change wrt new formatting of unaffected lines > == > > --

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-16 Thread Oleksandr Andrushchenko
Hello, Roger! Please find the branch with all the conversions [1]. Unfortunately I cannot provide a branch as seen with diff --ignore-all-space as such a patch will not simply apply. Stay safe, Oleksandr Andrushchenko On 16.02.25 13:58, Andrew Cooper wrote: On 16/02/2025 10:21 am, Oleksandr An

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-16 Thread Andrew Cooper
On 16/02/2025 10:21 am, Oleksandr Andrushchenko wrote: > There are two diff files which show what happens in case the same is > applied to the whole xen/drivers directory: > - first one is the result of the "git diff" command, 1.2M [3] > - the second one is for "git diff --ignire-all-space", 600K [