Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-04-04 Thread Stefano Stabellini
On Wed, 19 Mar 2025, Jan Beulich wrote: > What about xenctl_bitmap_to_bitmap()? Let me see first if I managed to handle bitmap_to_xenctl_bitmap well. --- [PATCH v2] xen: simplify bitmap_to_xenctl_bitmap for little endian The little endian implementation of bitmap_to_xenctl_bitmap leads to unne

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-28 Thread Stefano Stabellini
On Fri, 28 Mar 2025, Jan Beulich wrote: > >>> + copy_to_guest(xenctl_bitmap->bitmap, bytemap, copy_bytes - > >>> 1) ) > >>> +err = -EFAULT; > >>> + > >>> +xfree(bytemap); > >>> +} > >>> +else > >>> +{ > >>> +const uint8_t *bytemap = (const uint8_

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-28 Thread Jan Beulich
On 28.03.2025 00:33, Stefano Stabellini wrote: > On Mon, 24 Mar 2025, Jan Beulich wrote: >> On 22.03.2025 00:09, Stefano Stabellini wrote: >>> @@ -384,21 +382,40 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap >>> *xenctl_bitmap, >>> uint8_t zero = 0; >>> int err = 0; >>> unsign

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-27 Thread Stefano Stabellini
On Mon, 24 Mar 2025, Jan Beulich wrote: > On 22.03.2025 00:09, Stefano Stabellini wrote: > > On Thu, 20 Mar 2025, Jan Beulich wrote: > >> On 20.03.2025 01:57, Stefano Stabellini wrote: > >>> On Wed, 19 Mar 2025, Jan Beulich wrote: > What about xenctl_bitmap_to_bitmap()? > >>> > >>> Let me se

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-24 Thread Jan Beulich
On 22.03.2025 00:09, Stefano Stabellini wrote: > On Thu, 20 Mar 2025, Jan Beulich wrote: >> On 20.03.2025 01:57, Stefano Stabellini wrote: >>> On Wed, 19 Mar 2025, Jan Beulich wrote: What about xenctl_bitmap_to_bitmap()? >>> >>> Let me see first if I managed to handle bitmap_to_xenctl_bitmap

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-21 Thread Stefano Stabellini
On Thu, 20 Mar 2025, Jan Beulich wrote: > On 20.03.2025 01:57, Stefano Stabellini wrote: > > On Wed, 19 Mar 2025, Jan Beulich wrote: > >> What about xenctl_bitmap_to_bitmap()? > > > > Let me see first if I managed to handle bitmap_to_xenctl_bitmap well. > > Well, the code looks correct to me, bu

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-20 Thread Jan Beulich
On 20.03.2025 01:57, Stefano Stabellini wrote: > On Wed, 19 Mar 2025, Jan Beulich wrote: >> What about xenctl_bitmap_to_bitmap()? > > Let me see first if I managed to handle bitmap_to_xenctl_bitmap well. Well, the code looks correct to me, but the description now has gone stale. I also wonder wh

Re: [PATCH] xen: simplify bitmap_to_xenctl_bitmap for little endian

2025-03-19 Thread Jan Beulich
On 19.03.2025 04:03, Stefano Stabellini wrote: > --- a/xen/common/bitmap.c > +++ b/xen/common/bitmap.c > @@ -384,21 +384,26 @@ int bitmap_to_xenctl_bitmap(struct xenctl_bitmap > *xenctl_bitmap, > uint8_t zero = 0; > int err = 0; > unsigned int xen_bytes = DIV_ROUND_UP(nbits, BITS_PE