Re: [PATCH] xen/x86: Fix memory leak in vcpu_create() error path

2020-12-21 Thread Jan Beulich
On 18.12.2020 14:58, Andrew Cooper wrote: > On 18/12/2020 08:27, Jan Beulich wrote: >> On 17.12.2020 22:46, Andrew Cooper wrote: >>> On 29/09/2020 07:18, Jan Beulich wrote: On 28.09.2020 17:47, Andrew Cooper wrote: > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c >>>

Re: [PATCH] xen/x86: Fix memory leak in vcpu_create() error path

2020-12-18 Thread Andrew Cooper
On 18/12/2020 08:27, Jan Beulich wrote: > On 17.12.2020 22:46, Andrew Cooper wrote: >> On 29/09/2020 07:18, Jan Beulich wrote: >>> On 28.09.2020 17:47, Andrew Cooper wrote: --- a/xen/arch/x86/mm/hap/hap.c +++ b/xen/arch/x86/mm/hap/hap.c @@ -563,30 +563,37 @@ void hap_final_teardown(s

Re: [PATCH] xen/x86: Fix memory leak in vcpu_create() error path

2020-12-18 Thread Jan Beulich
On 17.12.2020 22:46, Andrew Cooper wrote: > On 29/09/2020 07:18, Jan Beulich wrote: >> On 28.09.2020 17:47, Andrew Cooper wrote: >>> --- a/xen/arch/x86/mm/hap/hap.c >>> +++ b/xen/arch/x86/mm/hap/hap.c >>> @@ -563,30 +563,37 @@ void hap_final_teardown(struct domain *d) >>> paging_unlock(d); >>>

Re: [PATCH] xen/x86: Fix memory leak in vcpu_create() error path

2020-12-17 Thread Andrew Cooper
On 29/09/2020 07:18, Jan Beulich wrote: > On 28.09.2020 17:47, Andrew Cooper wrote: >> Various paths in vcpu_create() end up calling paging_update_paging_modes(), >> which eventually allocate a monitor pagetable if one doesn't exist. >> >> However, an error in vcpu_create() results in the vcpu bein

Re: [PATCH] xen/x86: Fix memory leak in vcpu_create() error path

2020-09-28 Thread Jan Beulich
On 28.09.2020 17:47, Andrew Cooper wrote: > Various paths in vcpu_create() end up calling paging_update_paging_modes(), > which eventually allocate a monitor pagetable if one doesn't exist. > > However, an error in vcpu_create() results in the vcpu being cleaned up > locally, and not put onto the