Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-08 Thread Frediano Ziglio
On Tue, Jul 8, 2025 at 9:26 AM Jan Beulich wrote: > > On 08.07.2025 08:03, Frediano Ziglio wrote: > > On Mon, Jul 7, 2025 at 5:04 PM Jan Beulich wrote: > >> > >> On 07.07.2025 17:51, Frediano Ziglio wrote: > >>> On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: > > On 07.07.2025 17:11,

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-08 Thread Jan Beulich
On 08.07.2025 08:03, Frediano Ziglio wrote: > On Mon, Jul 7, 2025 at 5:04 PM Jan Beulich wrote: >> On 07.07.2025 17:51, Frediano Ziglio wrote: >>> On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: On 07.07.2025 17:11, Frediano Ziglio wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/c

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-08 Thread Jan Beulich
On 08.07.2025 08:03, Frediano Ziglio wrote: > On Mon, Jul 7, 2025 at 5:04 PM Jan Beulich wrote: >> >> On 07.07.2025 17:51, Frediano Ziglio wrote: >>> On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: On 07.07.2025 17:11, Frediano Ziglio wrote: > EFI code path split options from EFI

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-07 Thread Frediano Ziglio
On Mon, Jul 7, 2025 at 5:04 PM Jan Beulich wrote: > > On 07.07.2025 17:51, Frediano Ziglio wrote: > > On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: > >> > >> On 07.07.2025 17:11, Frediano Ziglio wrote: > >>> EFI code path split options from EFI LoadOptions fields in 2 > >>> pieces, first EFI

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-07 Thread Jan Beulich
On 07.07.2025 17:51, Frediano Ziglio wrote: > On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: >> >> On 07.07.2025 17:11, Frediano Ziglio wrote: >>> EFI code path split options from EFI LoadOptions fields in 2 >>> pieces, first EFI options, second Xen options. >>> "get_argv" function is called fi

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-07 Thread Frediano Ziglio
On Mon, Jul 7, 2025 at 4:42 PM Jan Beulich wrote: > > On 07.07.2025 17:11, Frediano Ziglio wrote: > > EFI code path split options from EFI LoadOptions fields in 2 > > pieces, first EFI options, second Xen options. > > "get_argv" function is called first to get the number of arguments > > in the Lo

Re: [PATCH] xen/efi: Fix crash with initial empty EFI options

2025-07-07 Thread Jan Beulich
On 07.07.2025 17:11, Frediano Ziglio wrote: > EFI code path split options from EFI LoadOptions fields in 2 > pieces, first EFI options, second Xen options. > "get_argv" function is called first to get the number of arguments > in the LoadOptions, second, after allocating enough space, to > fill som