Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Michal Orzel
On 29/11/2023 18:54, Julien Grall wrote: > > > Hi Michal, > > On 29/11/2023 18:41, Michal Orzel wrote: >> On 29/11/2023 18:17, Julien Grall wrote: >>> That said, I could settle on defining the two helpers in the *.c >>> directly because they are not meant to be used outside of a single *.c. >

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Julien Grall
Hi Michal, On 29/11/2023 18:41, Michal Orzel wrote: On 29/11/2023 18:17, Julien Grall wrote: That said, I could settle on defining the two helpers in the *.c directly because they are not meant to be used outside of a single *.c. Simarly... diff --git a/xen/arch/arm/include/asm/static-evtchn

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Michal Orzel
Hi Julien, On 29/11/2023 18:17, Julien Grall wrote: > > > Hi Michal > > On 29/11/2023 16:34, Michal Orzel wrote: >> Move static event channel feature related code to a separate module >> (static-evtchn.{c,h}) in the spirit of fine granular configuration, so >> that the feature can be disabled i

Re: [PATCH] xen/arm: Move static event channel feature to a separate module

2023-11-29 Thread Julien Grall
Hi Michal On 29/11/2023 16:34, Michal Orzel wrote: Move static event channel feature related code to a separate module (static-evtchn.{c,h}) in the spirit of fine granular configuration, so that the feature can be disabled if not needed. Introduce Kconfig option CONFIG_STATIC_EVTCHN, enabled by