Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Andrew Cooper
On 23/04/2021 12:08, Jan Beulich wrote: > On 23.04.2021 13:04, Andrew Cooper wrote: >> On 23/04/2021 11:58, Jan Beulich wrote: >>> On 23.04.2021 12:51, Andrew Cooper wrote: On 23/04/2021 10:50, Roger Pau Monné wrote: > On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: >> On

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Jan Beulich
On 23.04.2021 13:04, Andrew Cooper wrote: > On 23/04/2021 11:58, Jan Beulich wrote: >> On 23.04.2021 12:51, Andrew Cooper wrote: >>> On 23/04/2021 10:50, Roger Pau Monné wrote: On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: > On 16.04.2021 15:41, Andrew Cooper wrote: >> O

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Andrew Cooper
On 23/04/2021 11:58, Jan Beulich wrote: > On 23.04.2021 12:51, Andrew Cooper wrote: >> On 23/04/2021 10:50, Roger Pau Monné wrote: >>> On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: On 16.04.2021 15:41, Andrew Cooper wrote: > On 16/04/2021 09:16, Jan Beulich wrote: >> cla

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Jan Beulich
On 23.04.2021 12:51, Andrew Cooper wrote: > On 23/04/2021 10:50, Roger Pau Monné wrote: >> On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: >>> On 16.04.2021 15:41, Andrew Cooper wrote: On 16/04/2021 09:16, Jan Beulich wrote: > clang, at the very least, doesn't like unused inli

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Andrew Cooper
On 23/04/2021 10:50, Roger Pau Monné wrote: > On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: >> On 16.04.2021 15:41, Andrew Cooper wrote: >>> On 16/04/2021 09:16, Jan Beulich wrote: clang, at the very least, doesn't like unused inline functions, unless their definitions live

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-23 Thread Roger Pau Monné
On Fri, Apr 16, 2021 at 04:20:59PM +0200, Jan Beulich wrote: > On 16.04.2021 15:41, Andrew Cooper wrote: > > On 16/04/2021 09:16, Jan Beulich wrote: > >> clang, at the very least, doesn't like unused inline functions, unless > >> their definitions live in a header. > >> > >> Fixes: d23d792478 ("x86

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-16 Thread Jan Beulich
On 16.04.2021 15:41, Andrew Cooper wrote: > On 16/04/2021 09:16, Jan Beulich wrote: >> clang, at the very least, doesn't like unused inline functions, unless >> their definitions live in a header. >> >> Fixes: d23d792478 ("x86: avoid building COMPAT code when !HVM && !PV32") >> Reported-by: Andrew

Re: [PATCH] x86/oprof: fix !HVM && !PV32 build

2021-04-16 Thread Andrew Cooper
On 16/04/2021 09:16, Jan Beulich wrote: > clang, at the very least, doesn't like unused inline functions, unless > their definitions live in a header. > > Fixes: d23d792478 ("x86: avoid building COMPAT code when !HVM && !PV32") > Reported-by: Andrew Cooper > Signed-off-by: Jan Beulich I agree th