Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Denis Mukhin
On Friday, March 14th, 2025 at 1:51 AM, Jan Beulich wrote: > > > On 14.03.2025 02:20, dm...@proton.me wrote: > > > Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance > > readability. > > > > No functional changes. > > > > Signed-off-by: Denis Mukhin dmuk...@ford.com > > --

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Denis Mukhin
On Friday, March 14th, 2025 at 2:14 AM, Andrew Cooper wrote: > > > On 14/03/2025 1:20 am, dm...@proton.me wrote: > > > Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance > > readability. > > > > No functional changes. > > > > Signed-off-by: Denis Mukhin dmuk...@ford.com >

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Jan Beulich
On 14.03.2025 10:14, Andrew Cooper wrote: > On 14/03/2025 1:20 am, dm...@proton.me wrote: >> Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance >> readability. >> >> No functional changes. >> >> Signed-off-by: Denis Mukhin > > There are currently very few uses of NR_ISAIRQS, an

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Jan Beulich
On 14.03.2025 02:20, dm...@proton.me wrote: > Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance > readability. > > No functional changes. > > Signed-off-by: Denis Mukhin > --- > xen/arch/x86/hvm/dm.c | 2 +- > xen/arch/x86/hvm/irq.c | 17 + >

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Andrew Cooper
On 14/03/2025 9:16 am, Jan Beulich wrote: > On 14.03.2025 10:14, Andrew Cooper wrote: >> On 14/03/2025 1:20 am, dm...@proton.me wrote: >>> Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance >>> readability. >>> >>> No functional changes. >>> >>> Signed-off-by: Denis Mukhin >> Th

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Andrew Cooper
On 14/03/2025 8:51 am, Jan Beulich wrote: > On 14.03.2025 02:20, dm...@proton.me wrote: >> Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance >> readability. >> >> No functional changes. >> >> Signed-off-by: Denis Mukhin >> --- >> xen/arch/x86/hvm/dm.c | 2 +- >> xen/

Re: [PATCH] x86/irq: use NR_ISAIRQS instead of open-coded value

2025-03-14 Thread Andrew Cooper
On 14/03/2025 1:20 am, dm...@proton.me wrote: > Replace the open-coded value 16 with the NR_ISAIRQS symbol to enhance > readability. > > No functional changes. > > Signed-off-by: Denis Mukhin There are currently very few uses of NR_ISAIRQS, and you're about tripling that. Please could you do a p