Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-30 Thread Costin Lupu
On 7/27/21 4:36 PM, Andrew Cooper wrote: > On 16/07/2021 19:28, Costin Lupu wrote: >> On 7/13/21 6:20 PM, Juergen Gross wrote: >>> On 13.07.21 17:15, Julien Grall wrote: Hi Juergen, On 13/07/2021 16:09, Juergen Gross wrote: > On 13.07.21 16:38, Julien Grall wrote: >> Hi Juerg

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-27 Thread Andrew Cooper
On 16/07/2021 19:28, Costin Lupu wrote: > On 7/13/21 6:20 PM, Juergen Gross wrote: >> On 13.07.21 17:15, Julien Grall wrote: >>> Hi Juergen, >>> >>> On 13/07/2021 16:09, Juergen Gross wrote: On 13.07.21 16:38, Julien Grall wrote: > Hi Juergen, > > On 13/07/2021 15:23, Juergen Gross

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-16 Thread Costin Lupu
On 7/13/21 6:20 PM, Juergen Gross wrote: > On 13.07.21 17:15, Julien Grall wrote: >> Hi Juergen, >> >> On 13/07/2021 16:09, Juergen Gross wrote: >>> On 13.07.21 16:38, Julien Grall wrote: Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: > On 13.07.21 16:19, Julien Grall wrot

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-14 Thread Julien Grall
On 14/07/2021 07:11, Jan Beulich wrote: On 13.07.2021 18:33, Julien Grall wrote: Hi, On 13/07/2021 17:27, Jan Beulich wrote: On 13.07.2021 18:15, Julien Grall wrote: On 13/07/2021 16:52, Jan Beulich wrote: On 13.07.2021 16:33, Julien Grall wrote: On 13/07/2021 15:23, Jan Beulich wrote:

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 18:33, Julien Grall wrote: > Hi, > > On 13/07/2021 17:27, Jan Beulich wrote: >> On 13.07.2021 18:15, Julien Grall wrote: >>> On 13/07/2021 16:52, Jan Beulich wrote: On 13.07.2021 16:33, Julien Grall wrote: > On 13/07/2021 15:23, Jan Beulich wrote: >> On 13.07.2021 16:19,

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi, On 13/07/2021 17:27, Jan Beulich wrote: On 13.07.2021 18:15, Julien Grall wrote: On 13/07/2021 16:52, Jan Beulich wrote: On 13.07.2021 16:33, Julien Grall wrote: On 13/07/2021 15:23, Jan Beulich wrote: On 13.07.2021 16:19, Julien Grall wrote: On 13/07/2021 15:14, Jan Beulich wrote: And

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 18:15, Julien Grall wrote: > On 13/07/2021 16:52, Jan Beulich wrote: >> On 13.07.2021 16:33, Julien Grall wrote: >>> On 13/07/2021 15:23, Jan Beulich wrote: On 13.07.2021 16:19, Julien Grall wrote: > On 13/07/2021 15:14, Jan Beulich wrote: >>> And I don't think it should

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Jan, On 13/07/2021 16:52, Jan Beulich wrote: On 13.07.2021 16:33, Julien Grall wrote: On 13/07/2021 15:23, Jan Beulich wrote: On 13.07.2021 16:19, Julien Grall wrote: On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 16:33, Julien Grall wrote: > On 13/07/2021 15:23, Jan Beulich wrote: >> On 13.07.2021 16:19, Julien Grall wrote: >>> On 13/07/2021 15:14, Jan Beulich wrote: > And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at le

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 17:15, Julien Grall wrote: Hi Juergen, On 13/07/2021 16:09, Juergen Gross wrote: On 13.07.21 16:38, Julien Grall wrote: Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: On 13.07.21 16:19, Julien Grall wrote: Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Juergen, On 13/07/2021 16:09, Juergen Gross wrote: On 13.07.21 16:38, Julien Grall wrote: Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: On 13.07.21 16:19, Julien Grall wrote: Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rathe

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 16:38, Julien Grall wrote: Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: On 13.07.21 16:19, Julien Grall wrote: Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: On 13.07.21 16:19, Julien Grall wrote: Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at least in principle. There shouldn't be

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
On 13/07/2021 15:23, Jan Beulich wrote: On 13.07.2021 16:19, Julien Grall wrote: On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at least in principle. There shouldn't be a build time setting

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 16:28, Jan Beulich wrote: On 13.07.2021 16:23, Juergen Gross wrote: On 13.07.21 16:19, Julien Grall wrote: On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at least in principle. The

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 16:23, Juergen Gross wrote: > On 13.07.21 16:19, Julien Grall wrote: >> On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. >>> >>> Even that doesn't seem right to me, at least in principle. There >>> shouldn't >>> be a

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 16:19, Julien Grall wrote: Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at least in principle. There shouldn't be a build time setting when it may vary at runtime. IOW o

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 16:19, Julien Grall wrote: > On 13/07/2021 15:14, Jan Beulich wrote: >>> And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. >> >> Even that doesn't seem right to me, at least in principle. There shouldn't >> be a build time setting when it may vary at runtime. IOW

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Jan, On 13/07/2021 15:14, Jan Beulich wrote: And I don't think it should be named XC_PAGE_*, but rather XEN_PAGE_*. Even that doesn't seem right to me, at least in principle. There shouldn't be a build time setting when it may vary at runtime. IOW on Arm I think a runtime query to the hyper

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Jan Beulich
On 13.07.2021 16:00, Juergen Gross wrote: > On 13.07.21 15:46, Costin Lupu wrote: >> Hi guys, >> >> On 7/13/21 4:00 PM, Julien Grall wrote: >>> >>> >>> On 13/07/2021 13:39, Andrew Cooper wrote: On 13/07/2021 12:53, Julien Grall wrote: > Hi Andrew, > > On 13/07/2021 12:23, Andrew Co

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 15:46, Costin Lupu wrote: Hi guys, On 7/13/21 4:00 PM, Julien Grall wrote: On 13/07/2021 13:39, Andrew Cooper wrote: On 13/07/2021 12:53, Julien Grall wrote: Hi Andrew, On 13/07/2021 12:23, Andrew Cooper wrote: On 13/07/2021 12:21, Julien Grall wrote: Hi Andrew, On 13/07/202

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Costin Lupu
Hi guys, On 7/13/21 4:00 PM, Julien Grall wrote: > > > On 13/07/2021 13:39, Andrew Cooper wrote: >> On 13/07/2021 12:53, Julien Grall wrote: >>> Hi Andrew, >>> >>> On 13/07/2021 12:23, Andrew Cooper wrote: On 13/07/2021 12:21, Julien Grall wrote: > Hi Andrew, > > On 13/07/2021 1

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
On 13/07/2021 13:39, Andrew Cooper wrote: On 13/07/2021 12:53, Julien Grall wrote: Hi Andrew, On 13/07/2021 12:23, Andrew Cooper wrote: On 13/07/2021 12:21, Julien Grall wrote: Hi Andrew, On 13/07/2021 10:35, Andrew Cooper wrote: On 13/07/2021 10:27, Juergen Gross wrote: On 13.07.21 11:

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Andrew Cooper
On 13/07/2021 12:53, Julien Grall wrote: > Hi Andrew, > > On 13/07/2021 12:23, Andrew Cooper wrote: >> On 13/07/2021 12:21, Julien Grall wrote: >>> Hi Andrew, >>> >>> On 13/07/2021 10:35, Andrew Cooper wrote: On 13/07/2021 10:27, Juergen Gross wrote: > On 13.07.21 11:20, Julien Grall wrote

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Andrew, On 13/07/2021 12:23, Andrew Cooper wrote: On 13/07/2021 12:21, Julien Grall wrote: Hi Andrew, On 13/07/2021 10:35, Andrew Cooper wrote: On 13/07/2021 10:27, Juergen Gross wrote: On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of x

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Andrew Cooper
On 13/07/2021 12:21, Julien Grall wrote: > Hi Andrew, > > On 13/07/2021 10:35, Andrew Cooper wrote: >> On 13/07/2021 10:27, Juergen Gross wrote: >>> On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and w

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
Hi Andrew, On 13/07/2021 10:35, Andrew Cooper wrote: On 13/07/2021 10:27, Juergen Gross wrote: On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and wreck the build in an interesting way: In file included from xen/stu

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 11:31, Julien Grall wrote: On 13/07/2021 10:27, Juergen Gross wrote: On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and wreck the build in an interesting way: In file included from xen/stubdom/include/

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Andrew Cooper
On 13/07/2021 10:27, Juergen Gross wrote: > On 13.07.21 11:20, Julien Grall wrote: >> From: Julien Grall >> >> Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and >> wreck the build in an interesting way: >> >> In file included from xen/stubdom/include/xen/domctl.h:39:0, >>  

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Julien Grall
On 13/07/2021 10:27, Juergen Gross wrote: On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and wreck the build in an interesting way: In file included from xen/stubdom/include/xen/domctl.h:39:0,   fr

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Juergen Gross
On 13.07.21 11:20, Julien Grall wrote: From: Julien Grall Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and wreck the build in an interesting way: In file included from xen/stubdom/include/xen/domctl.h:39:0, from xen/tools/include/xenctrl.h:36,

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-13 Thread Andrew Cooper
On 13/07/2021 10:20, Julien Grall wrote: > From: Julien Grall > > Commit 0dbb4be739c5 add the inclusion of xenctrl.h from private.h and > wreck the build in an interesting way: > > In file included from xen/stubdom/include/xen/domctl.h:39:0, > from xen/tools/include/xenctrl.h:36,