Re: [PATCH] stubdom/grub: avoid relying on start_info definition

2025-06-25 Thread Jürgen Groß
On 25.06.25 16:30, Andrew Cooper wrote: On 25/06/2025 3:28 pm, Jürgen Groß wrote: On 25.06.25 16:20, Jan Beulich wrote: On 25.06.2025 13:08, Juergen Gross wrote: @@ -432,3 +431,10 @@ out:   allocated = 0;   xc_interface_close(xc_handle );   } + +static void call_start_info_hook(stru

Re: [PATCH] stubdom/grub: avoid relying on start_info definition

2025-06-25 Thread Jan Beulich
On 25.06.2025 13:08, Juergen Gross wrote: > @@ -432,3 +431,10 @@ out: > allocated = 0; > xc_interface_close(xc_handle ); > } > + > +static void call_start_info_hook(struct xc_dom_image *dom) > +{ > +#undef start_info > +if ( dom->arch_hooks->start_info ) > +dom->arch_hooks->s

Re: [PATCH] stubdom/grub: avoid relying on start_info definition

2025-06-25 Thread Andrew Cooper
On 25/06/2025 3:28 pm, Jürgen Groß wrote: > On 25.06.25 16:20, Jan Beulich wrote: >> On 25.06.2025 13:08, Juergen Gross wrote: >>> @@ -432,3 +431,10 @@ out: >>>   allocated = 0; >>>   xc_interface_close(xc_handle ); >>>   } >>> + >>> +static void call_start_info_hook(struct xc_dom_image *do

Re: [PATCH] stubdom/grub: avoid relying on start_info definition

2025-06-25 Thread Jürgen Groß
On 25.06.25 16:20, Jan Beulich wrote: On 25.06.2025 13:08, Juergen Gross wrote: @@ -432,3 +431,10 @@ out: allocated = 0; xc_interface_close(xc_handle ); } + +static void call_start_info_hook(struct xc_dom_image *dom) +{ +#undef start_info +if ( dom->arch_hooks->start_info ) +

Re: [PATCH] stubdom/grub: avoid relying on start_info definition

2025-06-25 Thread Jason Andryuk
On 2025-06-25 07:08, Juergen Gross wrote: The kexec() function of grub-pv is relying on the exact definition of start_info from Mini-OS by having an "#undef start_info" and a few lines later a copy of the Mini-OS definition again. This is bad practice by making all attempts of Mini-OS to change