Re: [PATCH] libxl: only query VNC when enabled

2020-10-08 Thread Wei Liu
On Thu, Oct 08, 2020 at 09:31:15AM -0400, Jason Andryuk wrote: > On Wed, Oct 7, 2020 at 6:50 AM Wei Liu wrote: > > > > On Thu, Oct 01, 2020 at 07:53:37PM -0400, Jason Andryuk wrote: > > > QEMU without VNC support (configure --disable-vnc) will return an error > > > when VNC is queried over QMP sin

Re: [PATCH] libxl: only query VNC when enabled

2020-10-08 Thread Jason Andryuk
On Thu, Oct 8, 2020 at 9:31 AM Jason Andryuk wrote: > > On Wed, Oct 7, 2020 at 6:50 AM Wei Liu wrote: > > > > On Thu, Oct 01, 2020 at 07:53:37PM -0400, Jason Andryuk wrote: > > > QEMU without VNC support (configure --disable-vnc) will return an error > > > when VNC is queried over QMP since it do

Re: [PATCH] libxl: only query VNC when enabled

2020-10-08 Thread Jason Andryuk
On Wed, Oct 7, 2020 at 6:50 AM Wei Liu wrote: > > On Thu, Oct 01, 2020 at 07:53:37PM -0400, Jason Andryuk wrote: > > QEMU without VNC support (configure --disable-vnc) will return an error > > when VNC is queried over QMP since it does not recognize the QMP > > command. This will cause libxl to f

Re: [PATCH] libxl: only query VNC when enabled

2020-10-07 Thread Wei Liu
On Thu, Oct 01, 2020 at 07:53:37PM -0400, Jason Andryuk wrote: > QEMU without VNC support (configure --disable-vnc) will return an error > when VNC is queried over QMP since it does not recognize the QMP > command. This will cause libxl to fail starting the domain even if VNC > is not enabled. Th