Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Jan Beulich
On 10.05.2023 17:19, Roger Pau Monné wrote: > On Wed, May 10, 2023 at 03:30:21PM +0200, Jan Beulich wrote: >> On 10.05.2023 12:22, Roger Pau Monné wrote: >>> On Wed, May 10, 2023 at 12:00:51PM +0200, Jan Beulich wrote: On 10.05.2023 10:27, Roger Pau Monné wrote: > On Tue, May 09, 2023 at 0

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Roger Pau Monné
On Wed, May 10, 2023 at 03:30:21PM +0200, Jan Beulich wrote: > On 10.05.2023 12:22, Roger Pau Monné wrote: > > On Wed, May 10, 2023 at 12:00:51PM +0200, Jan Beulich wrote: > >> On 10.05.2023 10:27, Roger Pau Monné wrote: > >>> On Tue, May 09, 2023 at 06:06:45PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Jan Beulich
On 10.05.2023 12:22, Roger Pau Monné wrote: > On Wed, May 10, 2023 at 12:00:51PM +0200, Jan Beulich wrote: >> On 10.05.2023 10:27, Roger Pau Monné wrote: >>> On Tue, May 09, 2023 at 06:06:45PM +0200, Jan Beulich wrote: On 09.05.2023 12:41, Roger Pau Monne wrote: > When translating an addre

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Roger Pau Monné
On Wed, May 10, 2023 at 12:00:51PM +0200, Jan Beulich wrote: > On 10.05.2023 10:27, Roger Pau Monné wrote: > > On Tue, May 09, 2023 at 06:06:45PM +0200, Jan Beulich wrote: > >> On 09.05.2023 12:41, Roger Pau Monne wrote: > >>> When translating an address that falls inside of a superpage in the > >>

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Jan Beulich
On 10.05.2023 10:27, Roger Pau Monné wrote: > On Tue, May 09, 2023 at 06:06:45PM +0200, Jan Beulich wrote: >> On 09.05.2023 12:41, Roger Pau Monne wrote: >>> When translating an address that falls inside of a superpage in the >>> IOMMU page tables the fetching of the PTE physical address field >>>

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-10 Thread Roger Pau Monné
On Tue, May 09, 2023 at 06:06:45PM +0200, Jan Beulich wrote: > On 09.05.2023 12:41, Roger Pau Monne wrote: > > When translating an address that falls inside of a superpage in the > > IOMMU page tables the fetching of the PTE physical address field > > wasn't using dma_pte_addr(), which caused the r

Re: [PATCH] iommu/vtd: fix address translation for superpages

2023-05-09 Thread Jan Beulich
On 09.05.2023 12:41, Roger Pau Monne wrote: > When translating an address that falls inside of a superpage in the > IOMMU page tables the fetching of the PTE physical address field > wasn't using dma_pte_addr(), which caused the returned data to be > corrupt as it would contain bits not related to