Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-12-05 Thread Julien Grall
Hi Alexander. On 04/12/2023 09:28, Alexander Kanavin wrote: On 12/1/23 20:14, Julien Grall wrote: So I agree that if we were to remove -Wdeclaration-after-statement then we should also update the CODING_STYLE. However, I am not entirely sure I would want to mix code and declaration in the hy

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-12-04 Thread Alexander Kanavin
On 12/1/23 20:14, Julien Grall wrote: So I agree that if we were to remove -Wdeclaration-after-statement then we should also update the CODING_STYLE. However, I am not entirely sure I would want to mix code and declaration in the hypervisor. Anyway, I think this is a separate discussion from

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-12-01 Thread Julien Grall
Hi Jan, On 30/11/2023 08:36, Jan Beulich wrote: On 29.11.2023 14:10, Anthony PERARD wrote: On Wed, Nov 29, 2023 at 11:47:24AM +0100, Julien Grall wrote: + Anthony for the tools + Juergen for Xenstored On 29/11/2023 11:34, Alexander Kanavin wrote: On 11/29/23 08:51, Jan Beulich wrote: On 28

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-30 Thread Jan Beulich
On 29.11.2023 14:10, Anthony PERARD wrote: > On Wed, Nov 29, 2023 at 11:47:24AM +0100, Julien Grall wrote: >> + Anthony for the tools >> + Juergen for Xenstored >> >> On 29/11/2023 11:34, Alexander Kanavin wrote: >>> On 11/29/23 08:51, Jan Beulich wrote: >>> On 28.11.2023 18:47, Alexander Kana

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Juergen Gross
On 29.11.23 11:47, Julien Grall wrote: Hi, + Anthony for the tools + Juergen for Xenstored On 29/11/2023 11:34, Alexander Kanavin wrote: On 11/29/23 08:51, Jan Beulich wrote: On 28.11.2023 18:47, Alexander Kanavin wrote: Such constructs are fully allowed by C99: https://gcc.gnu.org/onlinedo

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Anthony PERARD
On Wed, Nov 29, 2023 at 11:47:24AM +0100, Julien Grall wrote: > Hi, > > + Anthony for the tools > + Juergen for Xenstored > > On 29/11/2023 11:34, Alexander Kanavin wrote: > > On 11/29/23 08:51, Jan Beulich wrote: > > > > > On 28.11.2023 18:47, Alexander Kanavin wrote: > > > > Such constructs ar

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Jan Beulich
On 29.11.2023 11:34, Alexander Kanavin wrote: > On 11/29/23 08:51, Jan Beulich wrote: > >> On 28.11.2023 18:47, Alexander Kanavin wrote: >>> Such constructs are fully allowed by C99: >>> https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Julien Grall
Hi, + Anthony for the tools + Juergen for Xenstored On 29/11/2023 11:34, Alexander Kanavin wrote: On 11/29/23 08:51, Jan Beulich wrote: On 28.11.2023 18:47, Alexander Kanavin wrote: Such constructs are fully allowed by C99: https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Decla

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-29 Thread Alexander Kanavin
On 11/29/23 08:51, Jan Beulich wrote: On 28.11.2023 18:47, Alexander Kanavin wrote: Such constructs are fully allowed by C99: https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations There's more to this: It may also be a policy of ours (or

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-11-28 Thread Jan Beulich
On 28.11.2023 18:47, Alexander Kanavin wrote: > Such constructs are fully allowed by C99: > https://gcc.gnu.org/onlinedocs/gcc-12.2.0/gcc/Mixed-Labels-and-Declarations.html#Mixed-Labels-and-Declarations There's more to this: It may also be a policy of ours (or of any sub-component) to demand that