RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > > How about > > /* > > * For Arm32, set up the xenheap: up to 1GB of contiguous, > > * always-mapped memory. Base must be 32MB aligned and size > > * a multiple of 32MB. > > * For Arm64, set up the directmap area of memory. > > One remark. I would

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
On 07/09/2022 12:09, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- From: Julien Grall @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, I think the function also want to be renamed to match the code below. Hmmm, renaming the name to "s

RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > >>> @@ -609,7 +609,7 @@ void __init setup_xenheap_mappings(unsigned > >> long base_mfn, > >> > >> I think the function also want to be renamed to match the code below. > > > > Hmmm, renaming the name to "setup_directmap_mappings" woul

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
On 07/09/2022 11:53, Henry Wang wrote: -Original Message- From: Julien Grall Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_* Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e

RE: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to > directmap_* > > Hi Henry, > > On 07/09/2022 09:36, Henry Wang wrote: > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c &g

Re: [PATCH v3 3/4] xen/arm: mm: Rename xenheap_* variable to directmap_*

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7f5b317d3e..4a70ed2986 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -132,12 +132,12 @@ uint64_t init_ttbr; static paddr_t phys_offset; /* Limits of the Xen heap */ -mfn_