RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Stefano, > -Original Message- > From: Stefano Stabellini > > I would not block this series on the renaming for existing property (what > > matter is the new ones are consistent with the discussion). The renaming > could > > be done afterwards. I would even say post the feature freeze o

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Stefano Stabellini
On Wed, 7 Sep 2022, Stefano Stabellini wrote: > On Wed, 7 Sep 2022, Julien Grall wrote: > > On 07/09/2022 14:49, Henry Wang wrote: > > > > -Original Message- > > > > From: Bertrand Marquis > > > > > > > > But in any case we should only add one pair here for sure, as > > > > > > > > you >

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Stefano Stabellini
On Wed, 7 Sep 2022, Julien Grall wrote: > On 07/09/2022 14:49, Henry Wang wrote: > > > -Original Message- > > > From: Bertrand Marquis > > > > > > > But in any case we should only add one pair here for sure, as you > > > > > > > say > > > the > > > > > > > only implication is to add a coup

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > > I think I've addressed all comments from Julien regarding my series, > > If it is not too late for you would you be able to resend your series > without the 'address-cells'/'size-cells' change? This will give me the > opportunity t

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 15:04, Julien Grall wrote: Hi Henry, On 07/09/2022 14:49, Henry Wang wrote: -Original Message- From: Bertrand Marquis But in any case we should only add one pair here for sure, as you say the only implication is to add a couple of 0 in the worst case. I agree. The o

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 14:49, Henry Wang wrote: -Original Message- From: Bertrand Marquis But in any case we should only add one pair here for sure, as you say the only implication is to add a couple of 0 in the worst case. I agree. The only drawback is the need to modify the alrea

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi Henry, > On 7 Sep 2022, at 14:49, Henry Wang wrote: > > Hi Bertrand and Michal, > > I don't want to spam the email so I just reply here... > >> -Original Message- >> From: Bertrand Marquis >> But in any case we should only add one pair here for sure, as you say >> the >> on

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Bertrand and Michal, I don't want to spam the email so I just reply here... > -Original Message- > From: Bertrand Marquis > But in any case we should only add one pair here for sure, as you say > the > only implication is to add a couple of 0 in the worst case. > >>> I agree

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 14:37, Michal Orzel wrote: > > > > On 07/09/2022 15:33, Bertrand Marquis wrote: >> >>> On 7 Sep 2022, at 14:31, Michal Orzel wrote: >>> >>> >>> >>> On 07/09/2022 15:28, Bertrand Marquis wrote: Hi Michal, > On 7 Sep 2022, at 14:09, Michal Orzel

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi Henry, > On 7 Sep 2022, at 14:35, Henry Wang wrote: > > Hi Michal, > >> -Original Message- >> From: Michal Orzel >>> I am not convinced by the arguments on not using #address-cells and will >>> leave that one to Stefano >>> >>> But in any case we should only add one pair here for s

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 15:33, Bertrand Marquis wrote: > >> On 7 Sep 2022, at 14:31, Michal Orzel wrote: >> >> >> >> On 07/09/2022 15:28, Bertrand Marquis wrote: >>> >>> Hi Michal, >>> On 7 Sep 2022, at 14:09, Michal Orzel wrote: On 07/09/2022 14:45, Julien Grall wrote: > >

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Michal, > -Original Message- > From: Michal Orzel > > I am not convinced by the arguments on not using #address-cells and will > > leave that one to Stefano > > > > But in any case we should only add one pair here for sure, as you say the > > only implication is to add a couple of 0 in

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
> On 7 Sep 2022, at 14:31, Michal Orzel wrote: > > > > On 07/09/2022 15:28, Bertrand Marquis wrote: >> >> Hi Michal, >> >>> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >>> >>> >>> On 07/09/2022 14:45, Julien Grall wrote: On 07/09/2022 13:41, Michal Orzel wrote: > >

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 15:28, Bertrand Marquis wrote: > > Hi Michal, > >> On 7 Sep 2022, at 14:09, Michal Orzel wrote: >> >> >> On 07/09/2022 14:45, Julien Grall wrote: >>> >>> On 07/09/2022 13:41, Michal Orzel wrote: On 07/09/2022 14:32, Julien Grall wrote: > [CAUTION: External Ema

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi Michal, > On 7 Sep 2022, at 14:09, Michal Orzel wrote: > > > On 07/09/2022 14:45, Julien Grall wrote: >> >> On 07/09/2022 13:41, Michal Orzel wrote: >>> >>> >>> On 07/09/2022 14:32, Julien Grall wrote: [CAUTION: External Email] On 07/09/2022 13:12, Michal Orzel wrote:

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 13:45, Julien Grall wrote: > > > > On 07/09/2022 13:41, Michal Orzel wrote: >> On 07/09/2022 14:32, Julien Grall wrote: >>> [CAUTION: External Email] >>> >>> On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> On 07/09/2022 13:36, Jul

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 14:45, Julien Grall wrote: > > On 07/09/2022 13:41, Michal Orzel wrote: >> >> >> On 07/09/2022 14:32, Julien Grall wrote: >>> [CAUTION: External Email] >>> >>> On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> On 07/09/2022 13:36, Julien Grall wro

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:41, Michal Orzel wrote: On 07/09/2022 14:32, Julien Grall wrote: [CAUTION: External Email] On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, Hi Michal, On 07/09/2022 13:36, Julien Grall wrote: Hi Henry, While reviewing the binding sent by Penny I noticed some inc

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
On 07/09/2022 14:32, Julien Grall wrote: > [CAUTION: External Email] > > On 07/09/2022 13:12, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 07/09/2022 13:36, Julien Grall wrote: >>> >>> Hi Henry, >>> >>> While reviewing the binding sent by Penny I noticed some inconsistency >>> wit

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:12, Bertrand Marquis wrote: Hi, Hi Bertrand, On 7 Sep 2022, at 12:48, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory Hi Henry, While reviewing the binding sent by

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
On 07/09/2022 13:12, Michal Orzel wrote: Hi Julien, Hi Michal, On 07/09/2022 13:36, Julien Grall wrote: Hi Henry, While reviewing the binding sent by Penny I noticed some inconsistency with the one you introduced. See below. On 07/09/2022 09:36, Henry Wang wrote: +- xen,static-heap +

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Michal Orzel
Hi Julien, On 07/09/2022 13:36, Julien Grall wrote: > > Hi Henry, > > While reviewing the binding sent by Penny I noticed some inconsistency > with the one you introduced. See below. > > On 07/09/2022 09:36, Henry Wang wrote: >> +- xen,static-heap >> + >> +Property under the top-level "chos

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Bertrand Marquis
Hi, > On 7 Sep 2022, at 12:48, Henry Wang wrote: > > Hi Julien, > >> -Original Message- >> From: Julien Grall >> Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory >> >> Hi Henry, >> >> While reviewing

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory > > Hi Henry, > > While reviewing the binding sent by Penny I noticed some inconsistency > with the one you introduced. See below.

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
Hi Henry, While reviewing the binding sent by Penny I noticed some inconsistency with the one you introduced. See below. On 07/09/2022 09:36, Henry Wang wrote: +- xen,static-heap + +Property under the top-level "chosen" node. It specifies the address +and size of Xen static heap memor

RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > > -/* find first memory range not bound to a Xen domain */ > > -for ( i = 0; i < mem->nr_banks && mem->bank[i].xen_domain; i++ ) > > +/* find first memory range not bound to a Xen domain nor heap */ > > This comment could

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory

2022-09-07 Thread Julien Grall
Hi Henry, On 07/09/2022 09:36, Henry Wang wrote: static int __init early_scan_node(const void *fdt, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b76a84e8f5..0741645014 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1038,9 +1038,11