Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-20 Thread Julien Grall
Hi Wei, On 14/01/2021 00:18, Wei Chen wrote: I think if we introduce an empty helper for Arm32, we can reduce the other chunk inside get_cycles. In addition, if we need to do the same work for Arm32 in the future, we may not need to modify get_cycles. I don't really follow this. I wasn't asking

RE: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-13 Thread Wei Chen
vel@lists.xenproject.org; > >> sstabell...@kernel.org > >> Cc: Bertrand Marquis ; Penny Zheng > >> ; Jiamei Xie ; nd > >> > >> Subject: Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles > >> for > >> Arm64 > >> >

Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-13 Thread Julien Grall
On 09/01/2021 12:16, Wei Chen wrote: HI Julien, Hi Wei, -Original Message- From: Julien Grall Sent: 2021年1月8日 19:56 To: Wei Chen ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Penny Zheng ; Jiamei Xie ; nd Subject: Re: [PATCH v2 2/2] xen/arm: Add

RE: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-09 Thread Wei Chen
HI Julien, > -Original Message- > From: Julien Grall > Sent: 2021年1月8日 19:56 > To: Wei Chen ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertrand Marquis ; Penny Zheng > ; Jiamei Xie ; nd > > Subject: Re: [PATCH v2 2/2] xen/arm: Add defe

Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-08 Thread Julien Grall
Hi Wei, On 08/01/2021 06:21, Wei Chen wrote: Per the discussion [1] on the mailing list, we'd better to have a barrier after reading CNTPCT in get_cycles. If there is not any barrier there. When get_cycles being used in some seqlock critical context in the future, the seqlock can be speculated p