Paul Durrant writes ("RE: [PATCH for-4.14] tools: check go compiler version if
present"):
> > Acked-by: Ian Jackson
> >
> > Paul, this should go into 4.14. Can I have a release ack plase ?
>
> You may...
>
> Release-acked-by: Paul Durrant
Thanks, pushed.
Ian.
> -Original Message-
> From: Ian Jackson
> Sent: 15 June 2020 15:42
> To: Nick Rosbrook
> Cc: xen-devel@lists.xenproject.org; p...@xen.org; George Dunlap
> ; Nick
> Rosbrook ; Wei Liu
> Subject: Re: [PATCH for-4.14] tools: check go compiler version if present
&
Nick Rosbrook writes ("Re: [PATCH for-4.14] tools: check go compiler version if
present"):
> > Ideally at some point maybe we would make this clearer but not now.
>
> Okay, sounds good.
>
> > Have you tested the situations you describe ? That might be a bette
> Ideally at some point maybe we would make this clearer but not now.
Okay, sounds good.
> Have you tested the situations you describe ? That might be a better
> way of checking that it's right than the code inspection which is
> obviously failing for me now...
Yes, I have tested the following
Nick Rosbrook writes ("Re: [PATCH for-4.14] tools: check go compiler version if
present"):
> On Fri, Jun 12, 2020 at 05:40:21PM +0100, Ian Jackson wrote:
> > Nick Rosbrook writes ("[PATCH for-4.14] tools: check go compiler version if
> > present"):
> > &g
> On Jun 12, 2020, at 3:31 PM, Nick Rosbrook wrote:
>
> Currently, no minimum go compiler version is required by the configure
> scripts. However, the go bindings actually will not build with some
> older versions of go. Add a check for a minimum go version of 1.11.1 in
> accordance with tools/g
On Fri, Jun 12, 2020 at 05:40:21PM +0100, Ian Jackson wrote:
> Nick Rosbrook writes ("[PATCH for-4.14] tools: check go compiler version if
> present"):
> > Currently, no minimum go compiler version is required by the configure
> > scripts. However, the go bindings actually will not build with some
Nick Rosbrook writes ("[PATCH for-4.14] tools: check go compiler version if
present"):
> Currently, no minimum go compiler version is required by the configure
> scripts. However, the go bindings actually will not build with some
> older versions of go. Add a check for a minimum go version of 1.11
