Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-24 Thread Jan Beulich
On 24.08.2020 18:39, Roger Pau Monné wrote: > Would you be fine with clearing the callback in vlapic_handle_EOI and Yes - as said, I'd prefer such a model. > then vlapic_set_irq_callback complaining if it finds there's a > previous callback different than the one provided already set for the > to

Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-24 Thread Roger Pau Monné
On Mon, Aug 24, 2020 at 06:07:28PM +0200, Jan Beulich wrote: > On 24.08.2020 16:44, Roger Pau Monné wrote: > > On Mon, Aug 24, 2020 at 04:06:31PM +0200, Jan Beulich wrote: > >> On 12.08.2020 14:47, Roger Pau Monne wrote: > >>> Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI >

Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-24 Thread Roger Pau Monné
On Mon, Aug 24, 2020 at 04:06:31PM +0200, Jan Beulich wrote: > On 12.08.2020 14:47, Roger Pau Monne wrote: > > Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI > > and instead use the newly introduced EOI callback mechanism in order > > to register a callback for MSI vectors i

Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-24 Thread Jan Beulich
On 24.08.2020 16:44, Roger Pau Monné wrote: > On Mon, Aug 24, 2020 at 04:06:31PM +0200, Jan Beulich wrote: >> On 12.08.2020 14:47, Roger Pau Monne wrote: >>> Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI >>> and instead use the newly introduced EOI callback mechanism in ord

Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-24 Thread Jan Beulich
On 12.08.2020 14:47, Roger Pau Monne wrote: > Remove the unconditional call to hvm_dpci_msi_eoi in vlapic_handle_EOI > and instead use the newly introduced EOI callback mechanism in order > to register a callback for MSI vectors injected from passed through > devices. In patch 2 you merely invoke

Re: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-13 Thread Roger Pau Monné
On Thu, Aug 13, 2020 at 09:19:30AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 12 August 2020 13:47 > > To: xen-devel@lists.xenproject.org > > Cc: Roger Pau Monne ; Jan Beulich > > ; Andrew Cooper > > ; Wei Liu ; Paul Durrant > > > > Subject: [P

RE: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks

2020-08-13 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 12 August 2020 13:47 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; Paul Durrant > > Subject: [PATCH 3/5] x86/vmsi: use the newly introduced EOI callbacks > > Remove the uncon