Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-12-02 Thread Julien Grall
Hi, On 30/11/2020 02:50, Tian, Kevin wrote: From: Julien Grall Sent: Thursday, November 19, 2020 10:52 PM From: Julien Grall When booting Xen with CONFIG_USBAN=y on Sandy Bridge, UBSAN will throw the following splat: (XEN) ===

RE: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-29 Thread Tian, Kevin
> From: Julien Grall > Sent: Thursday, November 19, 2020 10:52 PM > > From: Julien Grall > > When booting Xen with CONFIG_USBAN=y on Sandy Bridge, UBSAN will > throw > the following splat: > > (XEN) > > > (XEN) U

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-28 Thread Julien Grall
Hi, On 19/11/2020 14:52, Julien Grall wrote: From: Julien Grall When booting Xen with CONFIG_USBAN=y on Sandy Bridge, UBSAN will throw the following splat: (XEN) (XEN) UBSAN: Undefined behaviour in quirks.c:449:

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-19 Thread Andrew Cooper
On 19/11/2020 16:40, Julien Grall wrote: > > > On 19/11/2020 16:38, Andrew Cooper wrote: >> On 19/11/2020 14:52, Julien Grall wrote: >>> Note that splat is from 4.11.4 and not staging. Although, the >>> problem is >>> still present. >>> >>> This can be solved by making the first operand unsigned in

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-19 Thread Julien Grall
On 19/11/2020 16:38, Andrew Cooper wrote: On 19/11/2020 14:52, Julien Grall wrote: Note that splat is from 4.11.4 and not staging. Although, the problem is still present. This can be solved by making the first operand unsigned int. Signed-off-by: Julien Grall CR: https://code.amazon.com/r

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-19 Thread Andrew Cooper
On 19/11/2020 14:52, Julien Grall wrote: > Note that splat is from 4.11.4 and not staging. Although, the problem is > still present. > > This can be solved by making the first operand unsigned int. > > Signed-off-by: Julien Grall > > CR: https://code.amazon.com/reviews/CR-38873112 IIRC, this is a

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-19 Thread Julien Grall
Hi Jan, On 19/11/2020 15:02, Jan Beulich wrote: On 19.11.2020 15:52, Julien Grall wrote: From: Julien Grall When booting Xen with CONFIG_USBAN=y on Sandy Bridge, UBSAN will throw the following splat: (XEN) (XEN

Re: [PATCH] xen/iommu: vtd: Fix undefined behavior pci_vtd_quirks()

2020-11-19 Thread Jan Beulich
On 19.11.2020 15:52, Julien Grall wrote: > From: Julien Grall > > When booting Xen with CONFIG_USBAN=y on Sandy Bridge, UBSAN will throw > the following splat: > > (XEN) > > (XEN) UBSAN: Undefined behaviour in quir