Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 13:06, Jan Beulich wrote: > > On 25.10.2022 12:13, Luca Fancellu wrote: >> Here is an example to add a new justification in safe.json:: >> >> |{ >> |"version": "1.0", >> |"content": [ >> |{ >> |"id":"SAF-0-safe", >> |"analyser": { >>

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Jan Beulich
On 25.10.2022 12:13, Luca Fancellu wrote: > Here is an example to add a new justification in safe.json:: > > |{ > |"version": "1.0", > |"content": [ > |{ > |"id":"SAF-0-safe", > |"analyser": { > |"cppcheck": "misra-c2012-20.7", > |

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 10:36, Julien Grall wrote: > > > > On 25/10/2022 11:13, Luca Fancellu wrote: >> Hi all, > > Hi Luca, > > Some comments below if we plan to merge the doc in the tree. > >> This is the V2 of the proposal for deviations tagging in the Xen codebase, >> this includes >> al

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Julien Grall
On 25/10/2022 11:13, Luca Fancellu wrote: Hi all, Hi Luca, Some comments below if we plan to merge the doc in the tree. This is the V2 of the proposal for deviations tagging in the Xen codebase, this includes all the feedbacks from the FuSa session held at the Xen Summit 2022 and all the

Re: [v2] Proposal for deviations in static analyser findings

2022-10-26 Thread Luca Fancellu
> On 26 Oct 2022, at 00:24, Stefano Stabellini wrote: > > On Tue, 25 Oct 2022, Luca Fancellu wrote: >> Hi all, >> >> This is the V2 of the proposal for deviations tagging in the Xen codebase, >> this includes >> all the feedbacks from the FuSa session held at the Xen Summit 2022 and all >> t

Re: [v2] Proposal for deviations in static analyser findings

2022-10-25 Thread Stefano Stabellini
On Tue, 25 Oct 2022, Luca Fancellu wrote: > Hi all, > > This is the V2 of the proposal for deviations tagging in the Xen codebase, > this includes > all the feedbacks from the FuSa session held at the Xen Summit 2022 and all > the > feedbacks received in the previous proposal sent on the mailing

[v2] Proposal for deviations in static analyser findings

2022-10-25 Thread Luca Fancellu
Hi all, This is the V2 of the proposal for deviations tagging in the Xen codebase, this includes all the feedbacks from the FuSa session held at the Xen Summit 2022 and all the feedbacks received in the previous proposal sent on the mailing list. Here a link to the previous thread: https://list

Re: Proposal for deviations in static analyser findings

2022-10-19 Thread Jan Beulich
On 19.10.2022 09:52, Bertrand Marquis wrote: >> On 19 Oct 2022, at 07:38, Jan Beulich wrote: >> On 18.10.2022 18:11, Bertrand Marquis wrote: On 18 Oct 2022, at 16:29, Jan Beulich wrote: On 18.10.2022 17:17, Luca Fancellu wrote: >> On 13 Oct 2022, at 12:34, Jan Beulich wrote: >>

Re: Proposal for deviations in static analyser findings

2022-10-19 Thread Luca Fancellu
> On 19 Oct 2022, at 07:38, Jan Beulich wrote: > > On 18.10.2022 18:11, Bertrand Marquis wrote: >>> On 18 Oct 2022, at 16:29, Jan Beulich wrote: >>> On 18.10.2022 17:17, Luca Fancellu wrote: > On 13 Oct 2022, at 12:34, Jan Beulich wrote: > On 13.10.2022 12:11, Luca Fancellu wrote: >>>

Re: Proposal for deviations in static analyser findings

2022-10-19 Thread Bertrand Marquis
Hi Jan, > On 19 Oct 2022, at 07:38, Jan Beulich wrote: > > On 18.10.2022 18:11, Bertrand Marquis wrote: >>> On 18 Oct 2022, at 16:29, Jan Beulich wrote: >>> On 18.10.2022 17:17, Luca Fancellu wrote: > On 13 Oct 2022, at 12:34, Jan Beulich wrote: > On 13.10.2022 12:11, Luca Fancellu wro

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Jan Beulich
On 18.10.2022 18:11, Bertrand Marquis wrote: >> On 18 Oct 2022, at 16:29, Jan Beulich wrote: >> On 18.10.2022 17:17, Luca Fancellu wrote: On 13 Oct 2022, at 12:34, Jan Beulich wrote: On 13.10.2022 12:11, Luca Fancellu wrote: >> On 13 Oct 2022, at 08:50, Jan Beulich wrote: >> On

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Bertrand Marquis
Hi, > On 18 Oct 2022, at 16:29, Jan Beulich wrote: > > On 18.10.2022 17:17, Luca Fancellu wrote: >>> On 13 Oct 2022, at 12:34, Jan Beulich wrote: >>> On 13.10.2022 12:11, Luca Fancellu wrote: > On 13 Oct 2022, at 08:50, Jan Beulich wrote: > On 12.10.2022 18:00, Luca Fancellu wrote: >>>

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Jan Beulich
On 18.10.2022 17:49, Luca Fancellu wrote: >> On 18 Oct 2022, at 16:29, Jan Beulich wrote: >> On 18.10.2022 17:17, Luca Fancellu wrote: On 13 Oct 2022, at 12:34, Jan Beulich wrote: On 13.10.2022 12:11, Luca Fancellu wrote: >> On 13 Oct 2022, at 08:50, Jan Beulich wrote: >> Iirc

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Luca Fancellu
> On 18 Oct 2022, at 16:29, Jan Beulich wrote: > > On 18.10.2022 17:17, Luca Fancellu wrote: >>> On 13 Oct 2022, at 12:34, Jan Beulich wrote: >>> On 13.10.2022 12:11, Luca Fancellu wrote: > On 13 Oct 2022, at 08:50, Jan Beulich wrote: > On 12.10.2022 18:00, Luca Fancellu wrote: >>

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Jan Beulich
On 18.10.2022 17:17, Luca Fancellu wrote: >> On 13 Oct 2022, at 12:34, Jan Beulich wrote: >> On 13.10.2022 12:11, Luca Fancellu wrote: On 13 Oct 2022, at 08:50, Jan Beulich wrote: On 12.10.2022 18:00, Luca Fancellu wrote: > Entries in the database should never be removed, even if th

Re: Proposal for deviations in static analyser findings

2022-10-18 Thread Luca Fancellu
> On 13 Oct 2022, at 12:34, Jan Beulich wrote: > > On 13.10.2022 12:11, Luca Fancellu wrote: >>> On 13 Oct 2022, at 08:50, Jan Beulich wrote: >>> On 12.10.2022 18:00, Luca Fancellu wrote: In the Xen codebase, these tags will be used to document and suppress findings: - SA

Re: Proposal for deviations in static analyser findings

2022-10-13 Thread Jan Beulich
On 13.10.2022 12:11, Luca Fancellu wrote: >> On 13 Oct 2022, at 08:50, Jan Beulich wrote: >> On 12.10.2022 18:00, Luca Fancellu wrote: >>> In the Xen codebase, these tags will be used to document and suppress >>> findings: >>> >>> - SAF-X-safe: This tag means that the next line of code contains a

Re: Proposal for deviations in static analyser findings

2022-10-13 Thread Luca Fancellu
Hi Jan, > On 13 Oct 2022, at 08:50, Jan Beulich wrote: > > On 12.10.2022 18:00, Luca Fancellu wrote: >> Documenting violations >> == > > I expect this is mean to become an in-tree document at some point? Yes, this will become part of the documentation at some point. > >>

Re: Proposal for deviations in static analyser findings

2022-10-13 Thread Jan Beulich
On 12.10.2022 18:00, Luca Fancellu wrote: > Documenting violations > == I expect this is mean to become an in-tree document at some point? > Static analysers are used on the Xen codebase for both static analysis and > MISRA > compliance. > There might be the need to suppress

Proposal for deviations in static analyser findings

2022-10-12 Thread Luca Fancellu
Hi all, Here is a proposal to create a deviation system for all the static analyser finding from both generic static code checkers and MISRA compliance, as said before, there might be some case where we won’t fix a part of the code because the way it is written is safer than the proposed fix fr