On 2023-11-29 04:26, Stefano Stabellini wrote:
On Mon, 27 Nov 2023, Nicola Vetrini wrote:
> > /*
> > * TODO: make first_valid_mfn static when NUMA is supported on Arm, this
> > * is required because the dummy helpers are using it.
> > */
> > extern mfn_t first_valid_mfn;
> >
> > it should
On Mon, 27 Nov 2023, Nicola Vetrini wrote:
> > > /*
> > > * TODO: make first_valid_mfn static when NUMA is supported on Arm, this
> > > * is required because the dummy helpers are using it.
> > > */
> > > extern mfn_t first_valid_mfn;
> > >
> > > it should probably be deviated.
> >
> > NUMA
On 2023-11-28 09:56, Jan Beulich wrote:
On 24.11.2023 10:40, Nicola Vetrini wrote:
in xen/lib.h and xen/sort.h there are definitions of the functions
bsearch and sort that have no prior declarations, and therefore are
subject to a violation of MISRA C Rule 8.4.
I'm wondering whether it would be
On 24.11.2023 10:40, Nicola Vetrini wrote:
> in xen/lib.h and xen/sort.h there are definitions of the functions
> bsearch and sort that have no prior declarations, and therefore are
> subject to a violation of MISRA C Rule 8.4.
>
> I'm wondering whether it would be preferred
>
> 1. to put a dec
On 27.11.2023 18:57, Nicola Vetrini wrote:
> On 2023-11-27 15:59, Jan Beulich wrote:
>> On 27.11.2023 15:32, Nicola Vetrini wrote:
>>> - compat_set_{px,cx}_pminfo in x86/x86_64/cpufreq.c are perhaps
>>> declared
>>> with an autogenerated header?
>>
>> I don't think so. Only top-level hypercall han
On 2023-11-27 15:59, Jan Beulich wrote:
On 27.11.2023 15:32, Nicola Vetrini wrote:
Still on the matter of Rule 8.4, though not related to bsearch or
sort:
- the definition of do_mca in x86/cpu/mcheck/mca.c has the following
header:
#include /* for do_mca */
which in turn leads to x86/in
On 27.11.2023 15:32, Nicola Vetrini wrote:
> Still on the matter of Rule 8.4, though not related to bsearch or sort:
>
> - the definition of do_mca in x86/cpu/mcheck/mca.c has the following
> header:
>#include /* for do_mca */
>which in turn leads to x86/include/asm/hypercall.h, which in
On 2023-11-24 10:40, Nicola Vetrini wrote:
Hi all,
in xen/lib.h and xen/sort.h there are definitions of the functions
bsearch and sort that have no prior declarations, and therefore are
subject to a violation of MISRA C Rule 8.4.
I'm wondering whether it would be preferred
1. to put a decla
Hi all,
in xen/lib.h and xen/sort.h there are definitions of the functions
bsearch and sort that have no prior declarations, and therefore are
subject to a violation of MISRA C Rule 8.4.
I'm wondering whether it would be preferred
1. to put a declaration just before the definition, in lib.h
