Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-30 Thread David Woodhouse
On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: > On 24.10.23 12:41, Juergen Gross wrote: > > On 24.10.23 09:43, David Woodhouse wrote: > > > On Tue, 2023-10-24 at 08:53 +0200, Juergen Gross wrote: > > > > > > > > I'm puzzled. This path doesn't contain any of the RCU usage I've added > >

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-28 Thread David Woodhouse
On Wed, 2023-10-25 at 09:19 +0200, Juergen Gross wrote: > On 24.10.23 15:45, David Woodhouse wrote: > > On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: > > > > > > > I can probably change xen_send_IPI_one() to not need > > > > irq_get_chip_data(). > > > > > > David, could you test the at

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-25 Thread David Woodhouse
On Wed, 2023-10-25 at 17:10 +0100, David Woodhouse wrote: > On Wed, 2023-10-25 at 09:19 +0200, Juergen Gross wrote: > > On 24.10.23 15:45, David Woodhouse wrote: > > > On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: > > > > > > > > > I can probably change xen_send_IPI_one() to not need >

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-25 Thread David Woodhouse
On Wed, 2023-10-25 at 09:19 +0200, Juergen Gross wrote: > On 24.10.23 15:45, David Woodhouse wrote: > > On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: > > > > > > > I can probably change xen_send_IPI_one() to not need > > > > irq_get_chip_data(). > > > > > > David, could you test the at

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-25 Thread Juergen Gross
On 24.10.23 15:45, David Woodhouse wrote: On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: I can probably change xen_send_IPI_one() to not need irq_get_chip_data(). David, could you test the attached patch, please? Build tested only. No longer whines when offlining CPU1. Still trip

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-24 Thread David Woodhouse
On Tue, 2023-10-24 at 14:08 +0200, Juergen Gross wrote: > > > I can probably change xen_send_IPI_one() to not need irq_get_chip_data(). > > David, could you test the attached patch, please? Build tested only. No longer whines when offlining CPU1. Still triple-faults when bringing it back online

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-24 Thread Juergen Gross
On 24.10.23 12:41, Juergen Gross wrote: On 24.10.23 09:43, David Woodhouse wrote: On Tue, 2023-10-24 at 08:53 +0200, Juergen Gross wrote: I'm puzzled. This path doesn't contain any of the RCU usage I've added in commit 87797fad6cce. Are you sure that with just reverting commit 87797fad6cce th

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-24 Thread Juergen Gross
On 24.10.23 09:43, David Woodhouse wrote: On Tue, 2023-10-24 at 08:53 +0200, Juergen Gross wrote: I'm puzzled. This path doesn't contain any of the RCU usage I've added in commit 87797fad6cce. Are you sure that with just reverting commit 87797fad6cce the issue doesn't manifest anymore? I'd rat

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-24 Thread David Woodhouse
On Tue, 2023-10-24 at 08:43 +0100, David Woodhouse wrote: > On Tue, 2023-10-24 at 08:53 +0200, Juergen Gross wrote: > > > > I'm puzzled. This path doesn't contain any of the RCU usage I've added in > > commit 87797fad6cce. > > > > Are you sure that with just reverting commit 87797fad6cce the issu

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-24 Thread David Woodhouse
On Tue, 2023-10-24 at 08:53 +0200, Juergen Gross wrote: > > I'm puzzled. This path doesn't contain any of the RCU usage I've added in > commit 87797fad6cce. > > Are you sure that with just reverting commit 87797fad6cce the issue doesn't > manifest anymore? I'd rather expect commit 721255b9826b ha

Re: Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-23 Thread Juergen Gross
On 23.10.23 22:50, David Woodhouse wrote: Since commit 87797fad6cce ("xen/events: replace evtchn_rwlock with RCU"), I can no longer hotplug CPUs under Xen with lockdep enabled. (This is real Xen 4.17.1; annoyingly I have different failure modes with Xen guests under qemu/kvm and I'll deal with t

Lockdep show 6.6-rc regression in Xen HVM CPU hotplug

2023-10-23 Thread David Woodhouse
Since commit 87797fad6cce ("xen/events: replace evtchn_rwlock with RCU"), I can no longer hotplug CPUs under Xen with lockdep enabled. (This is real Xen 4.17.1; annoyingly I have different failure modes with Xen guests under qemu/kvm and I'll deal with those next.) Offlining complains thus: [roo