Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Roger Pau Monné
On Mon, Sep 02, 2024 at 03:50:05PM +, Anthony PERARD wrote: > On Mon, Sep 02, 2024 at 05:23:37PM +0200, Roger Pau Monné wrote: > > On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote: > > > On 02/09/2024 09:55, Roger Pau Monné wrote: > > > [snip] > > > > > > > > Thanks for your input.

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Anthony PERARD
On Mon, Sep 02, 2024 at 05:23:37PM +0200, Roger Pau Monné wrote: > On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote: > > On 02/09/2024 09:55, Roger Pau Monné wrote: > > [snip] > > > > > > Thanks for your input. I would also like to hear from the blktap and > > > Windows PV drivers main

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Roger Pau Monné
On Mon, Sep 02, 2024 at 03:50:17PM +0100, Mark Syms wrote: > On Mon, 2 Sept 2024 at 09:55, Roger Pau Monné wrote: > > > > > So yes, after more research, having sector in the protocol been a > > > 512-byte size seems the least bad option. "sector_number" and > > > "{first,last}_sect" have been desc

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Paul Durrant
On 02/09/2024 16:23, Roger Pau Monné wrote: On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote: On 02/09/2024 09:55, Roger Pau Monné wrote: [snip] Thanks for your input. I would also like to hear from the blktap and Windows PV drivers maintainers, as the change that I'm proposing he

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Roger Pau Monné
On Mon, Sep 02, 2024 at 03:19:56PM +0100, Paul Durrant wrote: > On 02/09/2024 09:55, Roger Pau Monné wrote: > [snip] > > > > Thanks for your input. I would also like to hear from the blktap and > > Windows PV drivers maintainers, as the change that I'm proposing here > > will require changes to t

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Mark Syms
On Mon, 2 Sept 2024 at 09:55, Roger Pau Monné wrote: > > > So yes, after more research, having sector in the protocol been a > > 512-byte size seems the least bad option. "sector_number" and > > "{first,last}_sect" have been described as is for a long while. Only > > "sectors" for the size has bee

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Paul Durrant
On 02/09/2024 09:55, Roger Pau Monné wrote: [snip] Thanks for your input. I would also like to hear from the blktap and Windows PV drivers maintainers, as the change that I'm proposing here will require changes to their implementations. So IIUC you are proposing to refuse to connect to a fro

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-09-02 Thread Roger Pau Monné
On Fri, Aug 30, 2024 at 04:09:25PM +, Anthony PERARD wrote: > On Thu, Aug 29, 2024 at 05:42:45PM +0200, Roger Pau Monné wrote: > > On Thu, Aug 29, 2024 at 01:15:42PM +, Anthony PERARD wrote: > > > On Thu, Aug 29, 2024 at 12:59:43PM +0200, Roger Pau Monné wrote: > > > > The following table a

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-08-30 Thread Anthony PERARD
On Thu, Aug 29, 2024 at 05:42:45PM +0200, Roger Pau Monné wrote: > On Thu, Aug 29, 2024 at 01:15:42PM +, Anthony PERARD wrote: > > On Thu, Aug 29, 2024 at 12:59:43PM +0200, Roger Pau Monné wrote: > > > The following table attempts to summarize in which units the following > > > fields > > > ar

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-08-29 Thread Roger Pau Monné
On Thu, Aug 29, 2024 at 01:15:42PM +, Anthony PERARD wrote: > On Thu, Aug 29, 2024 at 12:59:43PM +0200, Roger Pau Monné wrote: > > Hello, > > > > To give some context, this started as a bug report against FreeBSD failing > > to > > work with PV blkif attached disks with 4K logical sectors when

Re: Block protocol incompatibilities with 4K logical sector size disks

2024-08-29 Thread Anthony PERARD
On Thu, Aug 29, 2024 at 12:59:43PM +0200, Roger Pau Monné wrote: > Hello, > > To give some context, this started as a bug report against FreeBSD failing to > work with PV blkif attached disks with 4K logical sectors when the backend is > Linux kernel blkback: > > https://bugs.freebsd.org/bugzilla/s

Block protocol incompatibilities with 4K logical sector size disks

2024-08-29 Thread Roger Pau Monné
Hello, To give some context, this started as a bug report against FreeBSD failing to work with PV blkif attached disks with 4K logical sectors when the backend is Linux kernel blkback: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280884 Further investigation has lead me to discover that the