Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-08 Thread Cédric Le Goater
On 12/7/21 21:42, Thomas Gleixner wrote: Cedric, On Tue, Dec 07 2021 at 16:50, Cédric Le Goater wrote: On 12/7/21 12:36, Michael Ellerman wrote: This patch should drop those selects I guess. Can you send an incremental diff for Thomas to squash in? Sure. Removing all the tendrils in vario

Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-07 Thread Thomas Gleixner
Cedric, On Tue, Dec 07 2021 at 16:50, Cédric Le Goater wrote: > On 12/7/21 12:36, Michael Ellerman wrote: >> >> This patch should drop those selects I guess. Can you send an >> incremental diff for Thomas to squash in? > > Sure. > >> Removing all the tendrils in various device tree files will pro

Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-07 Thread Cédric Le Goater
On 12/7/21 12:36, Michael Ellerman wrote: Cédric Le Goater writes: Hello Thomas, On 12/6/21 23:27, Thomas Gleixner wrote: This code is broken since day one. ppc4xx_setup_msi_irqs() has the following gems: 1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely broke

Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-07 Thread Michael Ellerman
Cédric Le Goater writes: > Hello Thomas, > > On 12/6/21 23:27, Thomas Gleixner wrote: >> This code is broken since day one. ppc4xx_setup_msi_irqs() has the >> following gems: >> >> 1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely >> broken: >> >> When the

Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-06 Thread Cédric Le Goater
Hello Thomas, On 12/6/21 23:27, Thomas Gleixner wrote: This code is broken since day one. ppc4xx_setup_msi_irqs() has the following gems: 1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely broken: When the result is greater than or equal 0 (bitmap allocat

[patch V2 01/23] powerpc/4xx: Remove MSI support which never worked

2021-12-06 Thread Thomas Gleixner
This code is broken since day one. ppc4xx_setup_msi_irqs() has the following gems: 1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely broken: When the result is greater than or equal 0 (bitmap allocation successful) then the loop terminates and the function