Hi Jan,
On 2020/1/21 19:13, Jan Beulich wrote:
> On 21.01.2020 04:44, Wei Xu wrote:
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -1620,6 +1620,66 @@ DT_DEVICE_START(ns16550, "NS16550 UART",
>> DEVICE_SERIAL)
>> DT_DEVICE_END
>>
>> #endif /* HAS_DEVICE_TREE
Hi Jan,
On 21/01/2020 11:25, Jan Beulich wrote:
On 21.01.2020 12:16, Julien Grall wrote:
On 21/01/2020 11:13, Jan Beulich wrote:
+if ( ACPI_FAILURE(status) )
+{
+printk("ns16550: Failed to get SPCR table\n");
Is such a message warranted? I.e. wouldn't it trigger on all
syst
On 21.01.2020 12:16, Julien Grall wrote:
> On 21/01/2020 11:13, Jan Beulich wrote:
>>
>>> +if ( ACPI_FAILURE(status) )
>>> +{
>>> +printk("ns16550: Failed to get SPCR table\n");
>>
>> Is such a message warranted? I.e. wouldn't it trigger on all
>> systems not having the table, which
On 21/01/2020 11:13, Jan Beulich wrote:
+if ( ACPI_FAILURE(status) )
+{
+printk("ns16550: Failed to get SPCR table\n");
Is such a message warranted? I.e. wouldn't it trigger on all
systems not having the table, which is hardly what you/we want?
+return -EINVAL;
A
On 21.01.2020 04:44, Wei Xu wrote:
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -1620,6 +1620,66 @@ DT_DEVICE_START(ns16550, "NS16550 UART", DEVICE_SERIAL)
> DT_DEVICE_END
>
> #endif /* HAS_DEVICE_TREE */
> +#if defined(CONFIG_ACPI) && defined(CONFIG_ARM)
Blank
Parse the ACPI SPCR table and initialize the 16550 compatible serial port
for ARM only. Currently we only support one UART on ARM. Some fields like
PCI, flow control and so on we do not care yet on ARM are ignored.
Signed-off-by: Wei Xu
---
Changes in v2:
- improve commit message
- remove the sp
