Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.12.2019 17:58, Vladimir Sementsov-Ogievskiy wrote: >> 05.12.2019 15:36, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> 04.12.2019 17:59, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Here is

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 17:58, Vladimir Sementsov-Ogievskiy wrote: > 05.12.2019 15:36, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 04.12.2019 17:59, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be use

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
05.12.2019 15:36, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 04.12.2019 17:59, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. >>

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 04.12.2019 17:59, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of >>> functions with errp OUT parameter. >>> >>> It has three goals: >>> >>> 1. Fix issue with erro

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Eric Blake
On 12/5/19 8:58 AM, Vladimir Sementsov-Ogievskiy wrote: What about you provide the examples, and then I try to polish the prose? 1: error_fatal problem Assume the following code flow: int f1(errp) { ... ret = f2(errp); if (ret < 0) { error_append_hint(errp, "very u

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-05 Thread Vladimir Sementsov-Ogievskiy
04.12.2019 17:59, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of >> functions with errp OUT parameter. >> >> It has three goals: >> >> 1. Fix issue with error_fatal & error_prepend/error_append_hint: user >

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-12-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_prepend/error_append_hint: user > can't see this additional information, because exit(

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 10:11 PM Vladimir Sementsov-Ogievskiy wrote: > > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal & error_prepend/error_append_hint: user > can't see this addi

Re: [Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-11-08 Thread Eric Blake
On 11/8/19 3:10 PM, Marc-André Lureau wrote: +/* + * ERRP_AUTO_PROPAGATE + * + * This macro is created to be the first line of a function with Error **errp + * OUT parameter. It's needed only in cases where we want to use error_prepend, + * error_append_hint or dereference *errp. It's still safe

[Xen-devel] [RFC v5 024/126] error: auto propagated local_err

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with errp OUT parameter. It has three goals: 1. Fix issue with error_fatal & error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than information is