Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Eric Blake
On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 3. What to do with huge auto-generated commit 07? Should I split it >>> per-maintainer or per-subsystem, or leave it as-is? >> >> It's big. I'd split it into multiple patches (and reduce the cc - except >> for the cover letter, the rest o

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2019 18:49, Vladimir Sementsov-Ogievskiy wrote: > 24.09.2019 18:46, Vladimir Sementsov-Ogievskiy wrote: >> 24.09.2019 18:44, Vladimir Sementsov-Ogievskiy wrote: >>> 24.09.2019 18:28, Eric Blake wrote: On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 3. What to do with

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2019 18:28, Eric Blake wrote: > On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: > 3. What to do with huge auto-generated commit 07? Should I split it per-maintainer or per-subsystem, or leave it as-is? >>> >>> It's big. I'd split it into multiple patches (and reduce the cc

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2019 18:44, Vladimir Sementsov-Ogievskiy wrote: > 24.09.2019 18:28, Eric Blake wrote: >> On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> > 3. What to do with huge auto-generated commit 07? Should I split it > per-maintainer or per-subsystem, or leave it as-is? It'

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
24.09.2019 18:46, Vladimir Sementsov-Ogievskiy wrote: > 24.09.2019 18:44, Vladimir Sementsov-Ogievskiy wrote: >> 24.09.2019 18:28, Eric Blake wrote: >>> On 9/24/19 9:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> >> 3. What to do with huge auto-generated commit 07? Should I split it >> per-

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
23.09.2019 22:47, Eric Blake wrote: > On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is a proposal of auto propagation for local_err, to not call >> error_propagate on every exit point, when we deal with local_err. >> >> It also fixes two issues: >> 1. Fix issue with

Re: [Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-23 Thread Eric Blake
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a proposal of auto propagation for local_err, to not call > error_propagate on every exit point, when we deal with local_err. > > It also fixes two issues: > 1. Fix issue with error_fatal & error_append_hint: user can'

[Xen-devel] [RFC v2 0/9] error: auto propagated local_err

2019-09-23 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a proposal of auto propagation for local_err, to not call error_propagate on every exit point, when we deal with local_err. It also fixes two issues: 1. Fix issue with error_fatal & error_append_hint: user can't see these hints, because exit() happens in error_setg earlier than hi