Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-02-12 Thread Tamas K Lengyel
On Tue, Feb 12, 2019 at 11:20 AM Razvan Cojocaru wrote: > > On 2/12/19 8:13 PM, Tamas K Lengyel wrote: > > On Tue, Jan 8, 2019 at 9:39 AM Razvan Cojocaru > > wrote: > >> > >> On 1/8/19 6:27 PM, Jan Beulich wrote: > >> On 19.12.18 at 19:52, wrote: > Signed-off-by: Petre Pircalabu > >>>

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-02-12 Thread Razvan Cojocaru
On 2/12/19 8:13 PM, Tamas K Lengyel wrote: > On Tue, Jan 8, 2019 at 9:39 AM Razvan Cojocaru > wrote: >> >> On 1/8/19 6:27 PM, Jan Beulich wrote: >> On 19.12.18 at 19:52, wrote: Signed-off-by: Petre Pircalabu >>> >>> An empty description is not helpful. The immediate question is: Why? >>

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-02-12 Thread Tamas K Lengyel
On Tue, Jan 8, 2019 at 9:39 AM Razvan Cojocaru wrote: > > On 1/8/19 6:27 PM, Jan Beulich wrote: > On 19.12.18 at 19:52, wrote: > >> Signed-off-by: Petre Pircalabu > > > > An empty description is not helpful. The immediate question is: Why? > > We don't do this for other interface versions.

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-02-12 Thread Jan Beulich
>>> On 12.02.19 at 17:57, wrote: > On Wed, 2019-01-09 at 11:11 +0200, Razvan Cojocaru wrote: >> >> On 1/8/19 6:47 PM, Jan Beulich wrote: >> > > > > On 08.01.19 at 17:37, wrote: >> > > >> > > On 1/8/19 6:27 PM, Jan Beulich wrote: >> > > > > > > On 19.12.18 at 19:52, wrote: >> > > > > >> > > >

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-02-12 Thread Petre Ovidiu PIRCALABU
On Wed, 2019-01-09 at 11:11 +0200, Razvan Cojocaru wrote: > > On 1/8/19 6:47 PM, Jan Beulich wrote: > > > > > On 08.01.19 at 17:37, wrote: > > > > > > On 1/8/19 6:27 PM, Jan Beulich wrote: > > > > > > > On 19.12.18 at 19:52, wrote: > > > > > > > > > > Signed-off-by: Petre Pircalabu > > > > >

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-01-09 Thread Razvan Cojocaru
On 1/8/19 6:47 PM, Jan Beulich wrote: On 08.01.19 at 17:37, wrote: On 1/8/19 6:27 PM, Jan Beulich wrote: On 19.12.18 at 19:52, wrote: Signed-off-by: Petre Pircalabu An empty description is not helpful. The immediate question is: Why? We don't do this for other interface versions. I'm un

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-01-08 Thread Jan Beulich
>>> On 08.01.19 at 17:37, wrote: > On 1/8/19 6:27 PM, Jan Beulich wrote: > On 19.12.18 at 19:52, wrote: >>> Signed-off-by: Petre Pircalabu >> >> An empty description is not helpful. The immediate question is: Why? >> We don't do this for other interface versions. I'm unconvinced a >> specia

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-01-08 Thread Razvan Cojocaru
On 1/8/19 6:27 PM, Jan Beulich wrote: On 19.12.18 at 19:52, wrote: Signed-off-by: Petre Pircalabu An empty description is not helpful. The immediate question is: Why? We don't do this for other interface versions. I'm unconvinced a special purpose piece of information like this one belongs i

Re: [Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2019-01-08 Thread Jan Beulich
>>> On 19.12.18 at 19:52, wrote: > Signed-off-by: Petre Pircalabu An empty description is not helpful. The immediate question is: Why? We don't do this for other interface versions. I'm unconvinced a special purpose piece of information like this one belongs into the rather generic version hyper

[Xen-devel] [RFC PATCH 6/6] xc_version: add vm_event interface version

2018-12-19 Thread Petre Pircalabu
Signed-off-by: Petre Pircalabu --- tools/libxc/xc_private.c | 3 +++ xen/common/kernel.c | 3 +++ xen/include/public/version.h | 3 +++ 3 files changed, 9 insertions(+) diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index 90974d5..9b983e0 100644 --- a/tools/libxc/x