Re: [Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-27 Thread hongyax
On 26/09/2019 14:16, Wei Liu wrote: On Thu, Sep 26, 2019 at 10:46:21AM +0100, hong...@amazon.com wrote: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index b2b2edbed1..145c5ab47c 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5160,6 +5160,7 @@ int map_pages_to_xen(

Re: [Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-26 Thread Wei Liu
On Thu, Sep 26, 2019 at 10:46:21AM +0100, hong...@amazon.com wrote: > From: Hongyan Xia > > Not unmapping pages after map_xen_pagetable can leak the virtual address > space over time. I understand this part, but ... > Also this fix makes vmap_to_mfn non-trivial to be a > macro. There might be b

Re: [Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-26 Thread Julien Grall
Hi, On 9/26/19 11:45 AM, hong...@amazon.com wrote: On 26/09/2019 11:23, Julien Grall wrote: Hi, NIT: we don't usually add full stop at the end of the title. This applies for the rest of the series. Thanks. On 9/26/19 10:46 AM, hong...@amazon.com wrote: From: Hongyan Xia Not unmapping

Re: [Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-26 Thread hongyax
On 26/09/2019 11:23, Julien Grall wrote: Hi, NIT: we don't usually add full stop at the end of the title. This applies for the rest of the series. Thanks. On 9/26/19 10:46 AM, hong...@amazon.com wrote: From: Hongyan Xia Not unmapping pages after map_xen_pagetable can leak the virtual ad

Re: [Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-26 Thread Julien Grall
Hi, NIT: we don't usually add full stop at the end of the title. This applies for the rest of the series. On 9/26/19 10:46 AM, hong...@amazon.com wrote: From: Hongyan Xia Not unmapping pages after map_xen_pagetable can leak the virtual address space over time. Also this fix makes vmap_to_mf

[Xen-devel] [RFC PATCH 58/84] x86/mm: fix leaks in map_xen_pagetable.

2019-09-26 Thread hongyax
From: Hongyan Xia Not unmapping pages after map_xen_pagetable can leak the virtual address space over time. Also this fix makes vmap_to_mfn non-trivial to be a macro. There might be better options but move it into vmap.c for now. Signed-off-by: Hongyan Xia --- xen/arch/x86/mm.c | 5 +