Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Paul Durrant
; Konrad Rzeszutek Wilk > ; Tim > (Xen.org) > Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers > > >>> On 18.03.19 at 18:06, wrote: > >> -Original Message- > >> From: Jan Beulich [mailto:jbeul...@s

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-19 Thread Jan Beulich
r Pau > Monne >> ; Wei Liu ; Stefano Stabellini > ; >> xen-devel ; Konrad Rzeszutek Wilk > ; Tim >> (Xen.org) >> Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers >> >> >>> On 18.03.19 at 17:26, wro

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
; Konrad Rzeszutek Wilk > ; Tim > (Xen.org) > Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers > > >>> On 18.03.19 at 17:26, wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] >

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Jan Beulich
>>> On 18.03.19 at 17:26, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 18 March 2019 16:23 >> >> >>> On 18.03.19 at 16:46, wrote: >> >> > > +{ >> >> > > +expiration = vs->count; >> >> > > +if ( expiration - now <= 0 ) >> >> > > +{ >> >> > > +

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
; Konrad Rzeszutek Wilk > ; Tim > (Xen.org) > Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers > > >>> On 18.03.19 at 16:46, wrote: > >> > > +{ > >> > > +expiration = vs->count

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Jan Beulich
>>> On 18.03.19 at 16:46, wrote: >> > > +{ >> > > +expiration = vs->count; >> > > +if ( expiration - now <= 0 ) >> > > +{ >> > > +vs->expiration = expiration; >> > > +stimer_expire(vs); >> > >> > Aren't you introducing a risk for races by calling

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Jan Beulich
>>> On 18.03.19 at 16:36, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf Of >> Jan Beulich >> Sent: 18 March 2019 15:21 >> >> >>> On 18.03.19 at 15:37, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: 18 March 2019 14:24 >> >> >> >> >>>

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
> -Original Message- [snip] > > > +{ > > > +expiration = vs->count; > > > +if ( expiration - now <= 0 ) > > > +{ > > > +vs->expiration = expiration; > > > +stimer_expire(vs); > > > > Aren't you introducing a risk for races by calling the t

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
; > George Dunlap ; Julien Grall > ; xen-devel de...@lists.xenproject.org>; Ian Jackson ; Roger Pau > Monne > > Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers > > >>> On 18.03.19 at 15:37, wrote: > >>

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Jan Beulich
>>> On 18.03.19 at 15:37, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 18 March 2019 14:24 >> >> >>> On 18.03.19 at 12:20, wrote: >> > @@ -72,11 +77,14 @@ static void update_reference_tsc(struct domain *d, >> > bool initialize) >> > * ticks per 100ns shifted left by 64.

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
el de...@lists.xenproject.org>; Konrad Rzeszutek Wilk ; > Tim (Xen.org) > > Subject: Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of > synthetic timers > > >>> On 18.03.19 at 12:20, wrote: > > @@ -72,11 +77,14 @@ static void update_reference_tsc(s

Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Jan Beulich
>>> On 18.03.19 at 12:20, wrote: > @@ -72,11 +77,14 @@ static void update_reference_tsc(struct domain *d, bool > initialize) > * ticks per 100ns shifted left by 64. > */ > p->TscScale = ((1ul << 32) / d->arch.tsc_khz) << 32; > +smp_wmb(); > + > +seq = p->TscSequence +

[Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers

2019-03-18 Thread Paul Durrant
This patch introduces an implementation of the STIMER0-15_CONFIG/COUNT MSRs and hence a the first SynIC message source. The new (and documented) 'stimer' viridian enlightenment group may be specified to enable this feature. While in the neighbourhood, this patch adds a missing check for an attemp