Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-09 Thread Jürgen Groß
On 10.10.19 07:57, Jan Beulich wrote: On 04.10.2019 19:28, Andrew Cooper wrote: On 04/10/2019 14:30, Jan Beulich wrote: On 04.10.2019 15:18, Andrew Cooper wrote: On 26/09/2019 15:28, Jan Beulich wrote: @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-09 Thread Jan Beulich
On 04.10.2019 19:28, Andrew Cooper wrote: > On 04/10/2019 14:30, Jan Beulich wrote: >> On 04.10.2019 15:18, Andrew Cooper wrote: >>> On 26/09/2019 15:28, Jan Beulich wrote: @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st IOMMU_PPR_LOG_DEFAU

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jürgen Groß
On 07.10.19 12:49, Jan Beulich wrote: On 07.10.2019 12:19, Jürgen Groß wrote: On 07.10.19 12:03, Jan Beulich wrote: I appreciate the ack, but I think I'd prefer to not make use of it if at all possible under these conditions. Instead I'd like us to reach some common ground here. Seeing that we

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jan Beulich
On 07.10.2019 12:19, Jürgen Groß wrote: > On 07.10.19 12:03, Jan Beulich wrote: >> I appreciate the ack, but I think I'd prefer to not make use of it >> if at all possible under these conditions. Instead I'd like us to >> reach some common ground here. Seeing that we're past the deadline >> alread

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jürgen Groß
On 07.10.19 12:03, Jan Beulich wrote: I appreciate the ack, but I think I'd prefer to not make use of it if at all possible under these conditions. Instead I'd like us to reach some common ground here. Seeing that we're past the deadline already, Jürgen's release ack will now be needed anyway. Jü

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-07 Thread Jan Beulich
On 04.10.2019 19:28, Andrew Cooper wrote: > On 04/10/2019 14:30, Jan Beulich wrote: >> On 04.10.2019 15:18, Andrew Cooper wrote: >>> On 26/09/2019 15:28, Jan Beulich wrote: @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st IOMMU_PPR_LOG_DEFAU

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Andrew Cooper
On 04/10/2019 14:30, Jan Beulich wrote: > On 04.10.2019 15:18, Andrew Cooper wrote: >> On 26/09/2019 15:28, Jan Beulich wrote: >>> @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st >>> IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); >>> } >>> >>> +/* >>>

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Jan Beulich
On 04.10.2019 15:18, Andrew Cooper wrote: > On 26/09/2019 15:28, Jan Beulich wrote: >> @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st >> IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); >> } >> >> +/* >> + * Within ivrs_mappings[] we allocate an extra

Re: [Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-10-04 Thread Andrew Cooper
On 26/09/2019 15:28, Jan Beulich wrote: > @@ -1068,8 +1067,29 @@ static void * __init allocate_ppr_log(st > IOMMU_PPR_LOG_DEFAULT_ENTRIES, "PPR Log"); > } > > +/* > + * Within ivrs_mappings[] we allocate an extra array element to store > + * - segment number, > +

[Xen-devel] [PATCH v7 1/3] AMD/IOMMU: allocate one device table per PCI segment

2019-09-26 Thread Jan Beulich
Having a single device table for all segments can't possibly be right. (Even worse, the symbol wasn't static despite being used in just one source file.) Attach the device tables to their respective IVRS mapping ones. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- v6: New. --- a/xen/d