Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-25 Thread Vladimir Sementsov-Ogievskiy
22.02.2020 11:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 21.02.2020 19:34, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 21.02.2020 10:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add functions to clean Error **errp: call corr

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-22 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 21.02.2020 19:34, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 21.02.2020 10:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Add functions to clean Error **errp: call corresponding Error *err >>>

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-21 Thread Eric Blake
On 2/21/20 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: +static inline void warn_report_errp(Error **errp) +{ +    assert(errp && *errp); +    warn_report_err(*errp); +    *errp = NULL; +} + +   /*    * Just like error_setg(), except you get to specify the error class.    * Note: use of error cl

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-21 Thread Vladimir Sementsov-Ogievskiy
21.02.2020 19:34, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 21.02.2020 10:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add functions to clean Error **errp: call corresponding Error *err cleaning function an set pointer to NULL. New functions: e

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-21 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 21.02.2020 10:38, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add functions to clean Error **errp: call corresponding Error *err >>> cleaning function an set pointer to NULL. >>> >>> New functions: >>>error_free_errp >>>e

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-21 Thread Vladimir Sementsov-Ogievskiy
21.02.2020 10:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add functions to clean Error **errp: call corresponding Error *err cleaning function an set pointer to NULL. New functions: error_free_errp error_report_errp warn_report_errp Signed-off-by: Vladimir Seme

Re: [Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-20 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add functions to clean Error **errp: call corresponding Error *err > cleaning function an set pointer to NULL. > > New functions: > error_free_errp > error_report_errp > warn_report_errp > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: G

[Xen-devel] [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
Add functions to clean Error **errp: call corresponding Error *err cleaning function an set pointer to NULL. New functions: error_free_errp error_report_errp warn_report_errp Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Eric Blake --- CC: Eric Blake C