Re: [Xen-devel] [PATCH v6 07/11] libxl_dm: Pre-open QMP socket for QEMU

2018-11-21 Thread Anthony PERARD
On Fri, Nov 16, 2018 at 11:52:52AM +, Ian Jackson wrote: > > +r = listen(fd, 1); > > What is the reasoning behind the choice of 1 for the listen queue > parameter ? I may have simply copy that from QEMU, or libvirt. They both call listen with 1. It is probably to allow at least one connec

Re: [Xen-devel] [PATCH v6 07/11] libxl_dm: Pre-open QMP socket for QEMU

2018-11-16 Thread Ian Jackson
Thanks for this patch. I have a feeling that I have already commented (perhaps informally) on a few aspects of it but the message was not marked `replied' in my MUA so I thought I would formally review it. Apologies if my comments are, effectively, duplicates. Anthony PERARD writes ("[PATCH v6 0

[Xen-devel] [PATCH v6 07/11] libxl_dm: Pre-open QMP socket for QEMU

2018-11-12 Thread Anthony PERARD
This patch move the creation of the QMP unix socket from QEMU to libxl. But libxl doesn't rely on this yet. When starting QEMU with dm_restrict=1, pre-open the QMP socket before exec QEMU. That socket will be usefull to findout if QEMU is ready, and pre-opening it means that libxl can connect to i