Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-07 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -13,6 +13,7 @@ obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o > obj-y += grant_table.o > obj-y += guestcopy.o > obj-bin-y += gunzip.init.o > +obj-$(CONFIG_X86) += iommu_op.o Btw - irrespective of this I think

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 13:55 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; Wei Liu > ; Stefano Stabellini ; xen- > devel ; Konrad Rzeszutek Wilk > ; Tim (Xen.org) > Subject: RE: [PATCH v6 05/

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Jan Beulich
>>> On 04.09.18 at 14:23, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 04 September 2018 12:50 >> >> >>> On 23.08.18 at 11:47, wrote: >> > +int compat_one_iommu_op(compat_iommu_op_buf_t *buf) >> > +{ >> > +compat_iommu_op_t cmp; >> > +xen_iommu_op_t nat; >> > +int

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 04 September 2018 12:50 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson ; Stefano Stabellini > ; xen-devel ; > Konrad Rzeszutek Wilk ; Tim (Xen.org) > > Subject: Re: [PATCH v6 05

Re: [Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-09-04 Thread Jan Beulich
>>> On 23.08.18 at 11:47, wrote: > --- /dev/null > +++ b/xen/common/iommu_op.c > @@ -0,0 +1,184 @@ > +/** > + * x86/iommu_op.c Oops? > +int do_one_iommu_op(xen_iommu_op_buf_t *buf) > +{ > +xen_iommu_op_t op; > +i

[Xen-devel] [PATCH v6 05/14] public / x86: introduce __HYPERCALL_iommu_op

2018-08-23 Thread Paul Durrant
This patch introduces the boilerplate for a new hypercall to allow a domain to control IOMMU mappings for its own pages. Whilst there is duplication of code between the native and compat entry points which appears ripe for some form of combination, I think it is better to maintain the separation as