Re: [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-09-17 Thread Andrew Cooper
On 06/08/2019 14:10, Jan Beulich wrote: > Rather than doing this every time we set up interrupts for a device > anew (and then in two distinct places) fill this invariant field > right after allocating struct arch_msix. > > While at it also obtain the MSI-X capability structure position just > once

Re: [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-08-06 Thread Jan Beulich
On 06.08.2019 17:16, Roger Pau Monné wrote: On Tue, Aug 06, 2019 at 04:47:28PM +0200, Jan Beulich wrote: On 06.08.2019 16:25, Roger Pau Monné wrote: On Tue, Aug 06, 2019 at 03:10:40PM +0200, Jan Beulich wrote: @@ -350,6 +353,10 @@ static struct pci_dev *ºalloc_pdev(struct retu

Re: [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-08-06 Thread Roger Pau Monné
On Tue, Aug 06, 2019 at 04:47:28PM +0200, Jan Beulich wrote: > On 06.08.2019 16:25, Roger Pau Monné wrote: > > On Tue, Aug 06, 2019 at 03:10:40PM +0200, Jan Beulich wrote: > > > --- a/xen/drivers/passthrough/pci.c > > > +++ b/xen/drivers/passthrough/pci.c > > > @@ -324,6 +324,7 @@ static void appl

Re: [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-08-06 Thread Jan Beulich
On 06.08.2019 16:25, Roger Pau Monné wrote: On Tue, Aug 06, 2019 at 03:10:40PM +0200, Jan Beulich wrote: @@ -1093,22 +1094,17 @@ static void __pci_disable_msi(struct msi **/ static int __pci_enable_msix(struct msi_info *msi, struct msi_desc **desc) { -int pos, nr_entries; struc

Re: [Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-08-06 Thread Roger Pau Monné
On Tue, Aug 06, 2019 at 03:10:40PM +0200, Jan Beulich wrote: > Rather than doing this every time we set up interrupts for a device > anew (and then in two distinct places) fill this invariant field > right after allocating struct arch_msix. > > While at it also obtain the MSI-X capability structur

[Xen-devel] [PATCH v5 08/10] x86/PCI: read MSI-X table entry count early

2019-08-06 Thread Jan Beulich
Rather than doing this every time we set up interrupts for a device anew (and then in two distinct places) fill this invariant field right after allocating struct arch_msix. While at it also obtain the MSI-X capability structure position just once, in msix_capability_init(), rather than in each c