Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-02 Thread Alexandru Stefan ISAILA
On 02.07.2019 11:01, Jan Beulich wrote: > On 02.07.2019 09:58, Alexandru Stefan ISAILA wrote: >> >> >> On 01.07.2019 18:53, Jan Beulich wrote: >>> On 01.07.2019 17:36, Alexandru Stefan ISAILA wrote: On 01.07.2019 17:55, Jan Beulich wrote: > On 01.07.2019 16:45, Alexandru Stefan ISAILA wr

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-02 Thread Jan Beulich
On 02.07.2019 09:58, Alexandru Stefan ISAILA wrote: > > > On 01.07.2019 18:53, Jan Beulich wrote: >> On 01.07.2019 17:36, Alexandru Stefan ISAILA wrote: >>> On 01.07.2019 17:55, Jan Beulich wrote: On 01.07.2019 16:45, Alexandru Stefan ISAILA wrote: > On 01.07.2019 16:13, Jan Beulich wrot

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-02 Thread Alexandru Stefan ISAILA
On 01.07.2019 18:53, Jan Beulich wrote: > On 01.07.2019 17:36, Alexandru Stefan ISAILA wrote: >> On 01.07.2019 17:55, Jan Beulich wrote: >>> On 01.07.2019 16:45, Alexandru Stefan ISAILA wrote: On 01.07.2019 16:13, Jan Beulich wrote: On 04.06.19 at 13:49, wrote: >> +if ( !re

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Jan Beulich
On 01.07.2019 17:36, Alexandru Stefan ISAILA wrote: > On 01.07.2019 17:55, Jan Beulich wrote: >> On 01.07.2019 16:45, Alexandru Stefan ISAILA wrote: >>> On 01.07.2019 16:13, Jan Beulich wrote: >>> On 04.06.19 at 13:49, wrote: > +if ( !req.u.mem_access.flags ) > +return fals

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Jan Beulich
On 01.07.2019 17:13, Razvan Cojocaru wrote: > On 7/1/19 5:45 PM, Alexandru Stefan ISAILA wrote: >> >> >> On 01.07.2019 16:13, Jan Beulich wrote: >> On 04.06.19 at 13:49, wrote: This patch aims to have mem access vm events sent from the emulator. This is useful where we want to only e

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Alexandru Stefan ISAILA
On 01.07.2019 17:55, Jan Beulich wrote: > On 01.07.2019 16:45, Alexandru Stefan ISAILA wrote: >> On 01.07.2019 16:13, Jan Beulich wrote: >> On 04.06.19 at 13:49, wrote: +if ( !send_event || !pfec ) +return false; >>> >>> I think I've said before that the !pfec part need

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Razvan Cojocaru
On 7/1/19 5:45 PM, Alexandru Stefan ISAILA wrote: On 01.07.2019 16:13, Jan Beulich wrote: On 04.06.19 at 13:49, wrote: This patch aims to have mem access vm events sent from the emulator. This is useful where we want to only emulate a page walk without checking the EPT, but we still want to

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Jan Beulich
On 01.07.2019 16:45, Alexandru Stefan ISAILA wrote: > On 01.07.2019 16:13, Jan Beulich wrote: > On 04.06.19 at 13:49, wrote: >>> +if ( !send_event || !pfec ) >>> +return false; >> >> I think I've said before that the !pfec part need an explanation (in >> a comment). Without such an

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Alexandru Stefan ISAILA
On 01.07.2019 16:13, Jan Beulich wrote: On 04.06.19 at 13:49, wrote: >> This patch aims to have mem access vm events sent from the emulator. >> This is useful where we want to only emulate a page walk without >> checking the EPT, but we still want to check the EPT when emulating >> the inst

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-07-01 Thread Jan Beulich
>>> On 04.06.19 at 13:49, wrote: > This patch aims to have mem access vm events sent from the emulator. > This is useful where we want to only emulate a page walk without > checking the EPT, but we still want to check the EPT when emulating > the instruction that caused the page walk. In this case

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-06-12 Thread Alexandru Stefan ISAILA
Hi all, Any remarks on the patch at hand are appreciated. Thanks, Alex On 04.06.2019 14:49, Alexandru Stefan ISAILA wrote: > This patch aims to have mem access vm events sent from the emulator. > This is useful where we want to only emulate a page walk without > checking the EPT, but we still wa

Re: [Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-06-11 Thread Paul Durrant
> -Original Message- > From: Alexandru Stefan ISAILA [mailto:aisa...@bitdefender.com] > Sent: 04 June 2019 12:50 > To: xen-devel@lists.xenproject.org > Cc: Paul Durrant ; jbeul...@suse.com; Andrew Cooper > ; w...@xen.org; Roger Pau Monne > ; > boris.ostrov...@oracle.com; suravee.suthikulpa

[Xen-devel] [PATCH v5] x86/emulate: Send vm_event from emulate

2019-06-04 Thread Alexandru Stefan ISAILA
This patch aims to have mem access vm events sent from the emulator. This is useful where we want to only emulate a page walk without checking the EPT, but we still want to check the EPT when emulating the instruction that caused the page walk. In this case, the original EPT fault is caused by the