Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-03-04 Thread Jan Beulich
>>> Roger Pau Monné 03/04/19 11:19 AM >>> >On Sun, Mar 03, 2019 at 02:10:24AM +0100, Marek Marczykowski wrote: >> On Thu, Feb 28, 2019 at 01:25:50PM +0100, Marek Marczykowski wrote: >> > On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: >> > > Another thing: You're also bypassing the MS

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-03-04 Thread Roger Pau Monné
On Sun, Mar 03, 2019 at 02:10:24AM +0100, Marek Marczykowski wrote: > On Thu, Feb 28, 2019 at 01:25:50PM +0100, Marek Marczykowski wrote: > > On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: > > > Another thing: You're also bypassing the MSI{,-X}-already-enabled > > > checks that __pci_

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-03-02 Thread Marek Marczykowski
On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: > >>> On 27.02.19 at 16:05, wrote: > > On Wed, Feb 27, 2019 at 04:41:37AM -0700, Jan Beulich wrote: > >> >>> On 07.02.19 at 01:07, wrote: > >> > +int msi_msix_set_enable(struct pci_dev *pdev, int mode, int enable) > >> > +{ > >> > +

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-03-02 Thread Marek Marczykowski
On Thu, Feb 28, 2019 at 01:25:50PM +0100, Marek Marczykowski wrote: > On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: > > Another thing: You're also bypassing the MSI{,-X}-already-enabled > > checks that __pci_enable_msi{,x}() do, yet allowing to enable both > > on a device would be a

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-28 Thread Marek Marczykowski
On Thu, Feb 28, 2019 at 03:58:37AM -0700, Jan Beulich wrote: > >>> On 27.02.19 at 16:05, wrote: > > On Wed, Feb 27, 2019 at 04:41:37AM -0700, Jan Beulich wrote: > >> >>> On 07.02.19 at 01:07, wrote: > >> > +int msi_msix_set_enable(struct pci_dev *pdev, int mode, int enable) > >> > +{ > >> > +

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-28 Thread Jan Beulich
>>> On 27.02.19 at 16:05, wrote: > On Wed, Feb 27, 2019 at 04:41:37AM -0700, Jan Beulich wrote: >> >>> On 07.02.19 at 01:07, wrote: >> > +int msi_msix_set_enable(struct pci_dev *pdev, int mode, int enable) >> > +{ >> > +int ret; >> > + >> > +ret = xsm_msi_set_enable(XSM_DM_PRIV, pdev->dom

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-27 Thread Marek Marczykowski
On Wed, Feb 27, 2019 at 04:41:37AM -0700, Jan Beulich wrote: > >>> On 07.02.19 at 01:07, wrote: > > --- a/xen/arch/x86/msi.c > > +++ b/xen/arch/x86/msi.c > > @@ -1474,6 +1474,30 @@ int pci_restore_msi_state(struct pci_dev *pdev) > > return 0; > > } > > > > +int msi_msix_set_enable(struct p

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-27 Thread Jan Beulich
>>> On 07.02.19 at 01:07, wrote: > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -1474,6 +1474,30 @@ int pci_restore_msi_state(struct pci_dev *pdev) > return 0; > } > > +int msi_msix_set_enable(struct pci_dev *pdev, int mode, int enable) unsigned int mode, bool enable I'm also

Re: [Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-07 Thread Roger Pau Monné
On Thu, Feb 07, 2019 at 01:07:48AM +0100, Marek Marczykowski-Górecki wrote: > Allow device model running in stubdomain to enable/disable MSI(-X), > bypassing pciback. While pciback is still used to access config space > from within stubdomain, it refuse to write to > PCI_MSI_FLAGS_ENABLE/PCI_MSIX_F

[Xen-devel] [PATCH v4 5/6] xen/x86: add PHYSDEVOP_msi_set_enable

2019-02-06 Thread Marek Marczykowski-Górecki
Allow device model running in stubdomain to enable/disable MSI(-X), bypassing pciback. While pciback is still used to access config space from within stubdomain, it refuse to write to PCI_MSI_FLAGS_ENABLE/PCI_MSIX_FLAGS_ENABLE in non-permissive mode. Which is the right thing to do for PV domain (th