Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-29 Thread Wei Liu
On Wed, Jan 29, 2020 at 03:59:32PM +0100, Jan Beulich wrote: [...] > >> I seem to recall recommending to export absolute symbols from > >> assembly code. The question is how easily usable they would > >> be from C, or how clumsy the resulting code would look. > > > > Even if I use absolute symbol

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-29 Thread Jan Beulich
On 29.01.2020 15:42, Wei Liu wrote: > On Tue, Jan 28, 2020 at 04:38:42PM +0100, Jan Beulich wrote: >> On 28.01.2020 16:15, Wei Liu wrote: >>> On Thu, Jan 23, 2020 at 12:04:00PM +0100, Jan Beulich wrote: On 22.01.2020 21:23, Wei Liu wrote: > This allows us to set aside some address space fo

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-29 Thread Wei Liu
On Tue, Jan 28, 2020 at 04:38:42PM +0100, Jan Beulich wrote: > On 28.01.2020 16:15, Wei Liu wrote: > > On Thu, Jan 23, 2020 at 12:04:00PM +0100, Jan Beulich wrote: > >> On 22.01.2020 21:23, Wei Liu wrote: > >>> This allows us to set aside some address space for executable mapping. > >>> This fixed

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-28 Thread Jan Beulich
On 28.01.2020 16:15, Wei Liu wrote: > On Thu, Jan 23, 2020 at 12:04:00PM +0100, Jan Beulich wrote: >> On 22.01.2020 21:23, Wei Liu wrote: >>> This allows us to set aside some address space for executable mapping. >>> This fixed map range starts from XEN_VIRT_END so that it is within reach >>> of th

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-28 Thread Wei Liu
On Thu, Jan 23, 2020 at 12:04:00PM +0100, Jan Beulich wrote: > On 22.01.2020 21:23, Wei Liu wrote: > > This allows us to set aside some address space for executable mapping. > > This fixed map range starts from XEN_VIRT_END so that it is within reach > > of the .text section. > > > > Shift the per

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-28 Thread Wei Liu
On Wed, Jan 22, 2020 at 08:56:55PM +, Andrew Cooper wrote: > On 22/01/2020 20:23, Wei Liu wrote: > > diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S > > index 1cbf5acdfb..605d01f1dd 100644 > > --- a/xen/arch/x86/boot/x86_64.S > > +++ b/xen/arch/x86/boot/x86_64.S > > @@ -85,

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-23 Thread Jan Beulich
On 22.01.2020 21:23, Wei Liu wrote: > This allows us to set aside some address space for executable mapping. > This fixed map range starts from XEN_VIRT_END so that it is within reach > of the .text section. > > Shift the percpu stub range and livepatch range accordingly. Hmm, the livepatch range

Re: [Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-22 Thread Andrew Cooper
On 22/01/2020 20:23, Wei Liu wrote: > diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S > index 1cbf5acdfb..605d01f1dd 100644 > --- a/xen/arch/x86/boot/x86_64.S > +++ b/xen/arch/x86/boot/x86_64.S > @@ -85,7 +85,15 @@ GLOBAL(l2_directmap) > * 4k page. > */ Adjust this comment

[Xen-devel] [PATCH v4 1/7] x86: provide executable fixmap facility

2020-01-22 Thread Wei Liu
This allows us to set aside some address space for executable mapping. This fixed map range starts from XEN_VIRT_END so that it is within reach of the .text section. Shift the percpu stub range and livepatch range accordingly. Signed-off-by: Wei Liu --- xen/arch/x86/boot/x86_64.S | 10 +++