Hi Lars,
On 18/12/2019 17:09, Lars Kurth wrote:
On 18/12/2019, 14:29, "Julien Grall" wrote:
Hi Lars,
On 12/12/2019 21:14, Lars Kurth wrote:
> +### Workflow from an Author's Perspective
> +
> +When code authors receive feedback on their patches, they typically
Ian Jackson writes ("Re: [PATCH v3 5/7] Add Code Review Guide"):
> Lars Kurth writes ("Re: [PATCH v3 5/7] Add Code Review Guide"):
> > In a nutshell, in such a review the possible interpretations are
> > * I reviewed, but didn't feel qualified to do the rest
> > * I reviewed, but did not get round
Lars Kurth writes ("Re: [PATCH v3 5/7] Add Code Review Guide"):
> In a nutshell, in such a review the possible interpretations are
> * I reviewed, but didn't feel qualified to do the rest
> * I reviewed, but did not get round to give it full attention
> * I reviewed, but before I make a final decis
On 19.12.2019 11:03, Lars Kurth wrote:
>
>
>> On 19 Dec 2019, at 09:56, Jan Beulich wrote:
>>
>> On 18.12.2019 18:09, Lars Kurth wrote:
>>>
>>>
>>> On 18/12/2019, 14:29, "Julien Grall" wrote:
>>>
>>>Hi Lars,
>>>
>>>On 12/12/2019 21:14, Lars Kurth wrote:
+### Workflow from an Autho
> On 19 Dec 2019, at 09:56, Jan Beulich wrote:
>
> On 18.12.2019 18:09, Lars Kurth wrote:
>>
>>
>> On 18/12/2019, 14:29, "Julien Grall" wrote:
>>
>>Hi Lars,
>>
>>On 12/12/2019 21:14, Lars Kurth wrote:
>>> +### Workflow from an Author's Perspective
>>> +
>>> +When code authors rece
On 18.12.2019 18:09, Lars Kurth wrote:
>
>
> On 18/12/2019, 14:29, "Julien Grall" wrote:
>
> Hi Lars,
>
> On 12/12/2019 21:14, Lars Kurth wrote:
> > +### Workflow from an Author's Perspective
> > +
> > +When code authors receive feedback on their patches, they typicall
On 18/12/2019, 14:29, "Julien Grall" wrote:
Hi Lars,
On 12/12/2019 21:14, Lars Kurth wrote:
> +### Workflow from an Author's Perspective
> +
> +When code authors receive feedback on their patches, they typically
first try
> +to clarify feedback they do not underst
Hi Lars,
On 12/12/2019 21:14, Lars Kurth wrote:
+### Workflow from an Author's Perspective
+
+When code authors receive feedback on their patches, they typically first try
+to clarify feedback they do not understand. For smaller patches or patch series
+it makes sense to wait until receiving fee
From: Lars Kurth
This document highlights what reviewers such as maintainers and committers look
for when reviewing code. It sets expectations for code authors and provides
a framework for code reviewers.
Changes since v2 (introduced in v2)
* Extend introduction
* Add "Code Review Workflow" cove
