Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 18:22, wrote: > On Mon, Jul 02, 2018 at 09:09:31AM -0600, Jan Beulich wrote: >> >>> On 02.07.18 at 16:54, wrote: >> > Ping? >> >> I don't understand: There's no open question in the quoted mail. > > It's more of a refute of your argument about assert of level triggered > inte

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Roger Pau Monné
On Mon, Jul 02, 2018 at 09:09:31AM -0600, Jan Beulich wrote: > >>> On 02.07.18 at 16:54, wrote: > > Ping? > > I don't understand: There's no open question in the quoted mail. It's more of a refute of your argument about assert of level triggered interrupts not being meaningful if the interrupt i

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Jan Beulich
>>> On 02.07.18 at 16:54, wrote: > Ping? I don't understand: There's no open question in the quoted mail. Jan > On Mon, Jun 25, 2018 at 01:19:19PM +0200, Roger Pau Monné wrote: >> On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: >> > >>> On 08.06.18 at 17:07, wrote: >> > > @@ -316,

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-07-02 Thread Roger Pau Monné
Ping? On Mon, Jun 25, 2018 at 01:19:19PM +0200, Roger Pau Monné wrote: > On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > > >>> On 08.06.18 at 17:07, wrote: > > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > > if ( pt->pending_intr_nr ) > > > { > > >

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-25 Thread Roger Pau Monné
On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > >>> On 08.06.18 at 17:07, wrote: > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > if ( pt->pending_intr_nr ) > > { > > /* RTC code takes care of disabling the timer itself. */ > > -

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-22 Thread Roger Pau Monné
On Fri, Jun 22, 2018 at 09:53:26AM -0600, Jan Beulich wrote: > >>> On 22.06.18 at 17:24, wrote: > > On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > >> >>> On 08.06.18 at 17:07, wrote: > >> > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > >> > if ( pt->pending_intr

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-22 Thread Jan Beulich
>>> On 22.06.18 at 17:24, wrote: > On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: >> >>> On 08.06.18 at 17:07, wrote: >> > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) >> > if ( pt->pending_intr_nr ) >> > { >> > /* RTC code takes care of disab

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-22 Thread Roger Pau Monné
On Fri, Jun 22, 2018 at 08:23:02AM -0600, Jan Beulich wrote: > >>> On 08.06.18 at 17:07, wrote: > > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > > if ( pt->pending_intr_nr ) > > { > > /* RTC code takes care of disabling the timer itself. */ > > -

Re: [Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-22 Thread Jan Beulich
>>> On 08.06.18 at 17:07, wrote: > @@ -316,7 +317,9 @@ int pt_update_irq(struct vcpu *v) > if ( pt->pending_intr_nr ) > { > /* RTC code takes care of disabling the timer itself. */ > -if ( (pt->irq != RTC_IRQ || !pt->priv) && pt_irq_masked(pt) ) > +

[Xen-devel] [PATCH v3 5/6] vpt: add support for level interrupts

2018-06-08 Thread Roger Pau Monne
Level trigger interrupts will be asserted regardless of whether the interrupt is masked, and thus the callback will also be executed. Add a new 'level' parameter to create_periodic_time in order to create level triggered timers. Note that none of the current users of vpt are switched to use level